[LTP] What is wrong with this program ?

Cyril Hrubis
2020-04-28T11:49:26Z

Hi!
> > > It fails with:
> > >
> > > safe_macros.c:230: BROK: foo.c:9: open(file,66,01) failed: EACCES (13)
> > >
> > > if run as a normal user and passes with sudo.
> >
> > I guess that you forget to pass the mode argument to the first
> > SAFE_OPEN() and hence the second one fails because the garbage passed to
> > mode prevents normal users from opening the file.
>
> Hmm, mode seems to be missing from a lot of syscall tests, which means that if
> they are run in a loop (with the cmdline way you mentioned earlier), then they
> will all fail.

If there is open() with O_CREAT without mode it's a bug.

--
Cyril Hrubis
chrubis@suse.cz