From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Tue, 28 Apr 2020 17:30:22 +0200 Subject: [LTP] [fs] ce436509a8: ltp.openat203.fail In-Reply-To: <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com> References: <20200427135210.GB5770@shao2-debian> <20200427142733.GD7661@rei> <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com> Message-ID: <20200428153022.GC4244@yuki.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds") > > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939 > > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next > > > > This commit adds fd parameter to the how structure where LTP test was > > previously passing garbage, which obviously causes the difference in > > errno. > > > > This could be safely ignored for now, if the patch gets merged the test > > needs to be updated. > > It wouldn't be a bad idea to switch the test to figure out the ksize of > the struct, so that you only add bad padding after that. But then again, > this would be a bit ugly -- having CHECK_FIELDS would make this simpler. Any pointers how can be the size figured out without relying on the E2BIG we are testing for? Does the kernel export it somewhere? -- Cyril Hrubis chrubis@suse.cz