public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission
Date: Tue, 5 May 2020 15:37:46 +0200	[thread overview]
Message-ID: <20200505133746.GB21884@dell5510> (raw)
In-Reply-To: <20200505101625.25020-1-rpalethorpe@suse.com>

Hi Richard,

> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---

Reviewed-by: Petr Vorel <pvorel@suse.cz>

BTW Every second run with this patch it blocks after pty04.c:214: PASS: Read netdev 1
and then:
tst_checkpoint.c:147: BROK: pty04.c:249: tst_checkpoint_wait(0, 10000): ETIMEDOUT (110)
tst_test.c:373: BROK: Reported by child (26650)
safe_macros.c:258: BROK: pty04.c:215: read(5,0x7efebc306001,8191) failed, returned -1: ENETDOWN (100)
pty04.c:139: PASS: Writing to PTY interrupted by hangup
tst_test.c:373: WARN: Reported by child (26648)

Tested on 5.7.0-rc3 in Tumbleweed.
But it looks this is not caused by this change, but was here before, because the
same behavior I see when testing pty04 *without* this patch on various kernels
(5.3.7, 5.6.0-rc5) and some of the never SLES (4.12 based).

Kind regards,
Petr

  parent reply	other threads:[~2020-05-05 13:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 10:16 [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission Richard Palethorpe
2020-05-05 10:16 ` [LTP] [PATCH v4 2/2] pty04: Add SLCAN ldisc and check for CVE-2020-11494 Richard Palethorpe
2020-05-05 13:35   ` Cyril Hrubis
2020-05-05 13:55     ` Petr Vorel
2020-05-05 15:18       ` Richard Palethorpe
2020-05-05 15:27         ` Petr Vorel
2020-05-05 13:37 ` Petr Vorel [this message]
2020-05-05 14:47   ` [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission Richard Palethorpe
2020-05-05 15:01     ` Petr Vorel
2020-05-05 15:11     ` Petr Vorel
2020-05-06  8:47     ` Richard Palethorpe
2020-05-06 10:49       ` Jan Stancek
2020-05-06 10:56         ` Li Wang
2020-05-06 11:14           ` Jan Stancek
2020-05-06 11:38             ` Petr Vorel
2020-05-06 12:06               ` Jan Stancek
2020-05-06 12:17                 ` Petr Vorel
2020-05-06 12:20                   ` Jan Stancek
2020-05-06 12:49             ` Cyril Hrubis
2020-05-06 13:49               ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505133746.GB21884@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox