public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/ioctl_loop05: Ensure do zero offset when using -i parameter
Date: Tue, 12 May 2020 11:58:32 +0200	[thread overview]
Message-ID: <20200512095832.GA3037@yuki.lan> (raw)
In-Reply-To: <1589260270-3636-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

Hi!
>  	memset(&loopinfo, 0, sizeof(loopinfo));
> +	/*
> +	 * Setting loopdevice with zero loop_info struct, so we can avoid unknown
> +	 * error when using -i parameter.
> +	 */
> +	TST_RETRY_FUNC(ioctl(dev_fd, LOOP_SET_STATUS, &loopinfo), TST_RETVAL_EQ0);

I've merged the patch without the comment, the commit message is
descriptive enough.

Thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2020-05-12  9:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  5:11 [LTP] [PATCH v2] syscalls/ioctl_loop05: Ensure do zero offset when using -i parameter Yang Xu
2020-05-12  9:58 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512095832.GA3037@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox