From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] rpc: Warn when tests aren't compiled
Date: Tue, 12 May 2020 21:50:33 +0200 [thread overview]
Message-ID: <20200512195033.GA3784@dell5510> (raw)
In-Reply-To: <d011a55b-a5b5-049f-9037-235d1f18cf1b@oracle.com>
Hi Alexey,
...
> > rpc_parse_args()
> > {
> > + local err="LTP compiled without TI-RPC support"
> > +
> > case "$1" in
> > - c) CLIENT="$OPTARG" ;;
> > - e) CLIENT_EXTRA_OPTS="$OPTARG" ;;
> > - s) SERVER="$OPTARG" ;;
> > + c) CLIENT="$OPTARG"; tst_cmd_available $OPTARG || tst_brk TCONF $err;;
> > + e) CLIENT_EXTRA_OPTS="$OPTARG";;
> > + s) SERVER="$OPTARG"; tst_cmd_available $OPTARG || tst_brk TCONF $err;;
> > esac
> Perhaps this one, to write about the missing command:
> tst_require_cmds $CLIENT $SERVER
> or just $CLIENT because it's always used, and if the hint is needed:
> tst_check_cmds $CLIENT $SERVER || tst_brk TCONF "LTP compiled without TI-RPC support?"
I prefer to have the hint, so I'll merge this variant.
Thanks for your review!
Kind regards,
Petr
prev parent reply other threads:[~2020-05-12 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:27 [LTP] [PATCH 1/1] rpc: Warn when tests aren't compiled Petr Vorel
2020-05-12 17:07 ` Alexey Kodanev
2020-05-12 19:50 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512195033.GA3784@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox