From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V4 1/1] syscall: Add io_uring test
Date: Fri, 15 May 2020 07:29:36 +0200 [thread overview]
Message-ID: <20200515052936.GA5117@dell5510> (raw)
In-Reply-To: <20200515040849.yu27rdihdih5wxc3@vireshk-i7>
Hi,
> On 14-05-20, 22:58, Vikas Kumar wrote:
> > Added Linux asynchronous I/O API Test for io_uring_setup(),
> > io_uring_register() and io_uring_enter().
> > This test will check io_uring api basic operation.
> > Signed-off-by: Vikas Kumar <vikas.kumar2@arm.com>
> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Please don't do this unless someone gave you this explicitly.
+1. By this you say Cyril considered your patch ready, which is not true.
Just on a brief look I see there needed to be some changes.
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-15 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 17:28 [LTP] [PATCH V4 0/1] syscall: Add io_uring test Vikas Kumar
2020-05-14 17:28 ` [LTP] [PATCH V4 1/1] " Vikas Kumar
2020-05-15 4:08 ` Viresh Kumar
2020-05-15 5:29 ` Petr Vorel [this message]
2020-05-18 4:33 ` Vikas Kumar
2020-05-18 7:22 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515052936.GA5117@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox