Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection
Date: Fri, 15 May 2020 12:53:36 +0200	[thread overview]
Message-ID: <20200515105336.GA2364@yuki.lan> (raw)
In-Reply-To: <20200514193011.11386-1-pvorel@suse.cz>

Hi!
> It's not enough to check for RPC headers. These can belong to libtirpc 64bit, which
> is not enough when compiling 32bit LTP without 32bit libtirpc.
> 
> Fixes: 60b20c428 ("rpc: Enable and fix build basic RPC tests with glibc SunRPC")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  m4/ltp-tirpc.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/m4/ltp-tirpc.m4 b/m4/ltp-tirpc.m4
> index 639e1e886..4d9701469 100644
> --- a/m4/ltp-tirpc.m4
> +++ b/m4/ltp-tirpc.m4
> @@ -17,9 +17,9 @@ AC_DEFUN([LTP_CHECK_TIRPC], [
>  	dnl rpc_broadcast() instead of clnt_broadcast()), but glibc implementation
>  	dnl does not have the new ones. We could either provide the deprecated
>  	dnl functions (copy from libtirpc src/rpc_soc.c) or drop glibc tests.
> -	AC_CHECK_HEADERS([rpc/rpc.h], [have_rpc_headers=yes])
> +	AC_CHECK_FUNCS([xdr_char clnttcp_create], [have_rpc_glibc=yes])
>  
> -	if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_headers" = "xyes"; then
> +	if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_glibc" = "xyes"; then
>  		AC_SUBST(HAVE_RPC, 1)
>  	fi

Looks good to me, if you have tested this throughly I would like to have
it in the release.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-05-15 10:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 19:30 [LTP] [PATCH 1/1] rpc-tirpc: Fix deprecated glibc detection Petr Vorel
2020-05-15 10:53 ` Cyril Hrubis [this message]
2020-05-15 11:00   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515105336.GA2364@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox