From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] rpc: TCONF when tests aren't compiled + remove kill warning
Date: Fri, 15 May 2020 14:17:16 +0200 [thread overview]
Message-ID: <20200515121716.GA23472@dell5510> (raw)
In-Reply-To: <20200515114507.GA3395@yuki.lan>
Hi Cyril,
> > > with this implementation (suggested by Alexey), we get TCONF twice. It's
> > > a bit strange, but I'll keep it, because I like that required binary is
> > > printed:
> > > rpc_test 1 TCONF: 'tirpc_rpcb_getaddr' not found
> > > rpc_test 1 TCONF: LTP compiled without TI-RPC support?
> > Please any comment for 2x TCONF. It's a bit strange, but just a tiny detail.
> > I'd like to have this fix in the release.
> I do not really care how many TCONF the test prints as long as the user
> gets a reasonable message.
Yep, it's a really tiny detail.
> With that the patch looks good, acked.
Thanks for your review, pushed.
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-15 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 20:14 [LTP] [PATCH v2 1/1] rpc: TCONF when tests aren't compiled + remove kill warning Petr Vorel
2020-05-14 14:47 ` Petr Vorel
2020-05-14 16:05 ` Xiao Yang
2020-05-14 16:52 ` Petr Vorel
2020-05-15 11:45 ` Cyril Hrubis
2020-05-15 12:17 ` Petr Vorel [this message]
2020-05-18 13:04 ` Xiao Yang
2020-05-18 21:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515121716.GA23472@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox