From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 4/4] umip_basic_test.c: improve kconfig verification to avoid umip wrong abort case
Date: Tue, 26 May 2020 12:11:33 +0200 [thread overview]
Message-ID: <20200526101133.GA3114075@x230> (raw)
In-Reply-To: <20200526100700.GA24819@xpf-desktop.sh.intel.com>
Hi Pengfei,
> > But it looks like Cyril is not against the implementation, it just needs to be
> > fixed:
> > https://patchwork.ozlabs.org/comment/2352151/
> You are right, actually it could be worked as my suggest way:
> "CONFIG_A|CONFIG_B=Y".
> I tried to use Cyril's advice "CONFIG_A=X|CONFIG_B=Y" way, which will
> add more code complexity, so I just want to solve the problem I am currently
> facing.
> If we really need the "CONFIG_A=X|CONFIG_B=Y" function, which cannot be
> satisfied by "CONFIG_A|CONFIG_B=Y" function in the future, then we could add
> this function I think.
> Thanks for your considering.
I'd also think that we need "CONFIG_A=X|CONFIG_B=Y", because
"CONFIG_A|CONFIG_B=Y" is ambiguous (we support both CONFIG_FOO and
CONFIG_FOO=bar and this must stay even with |).
Will you send a patch for that or shell I fix it with LINUX_VERSION_CODE <
KERNEL_VERSION for now?
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-26 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 9:25 [LTP] [PATCH v5 1/4] lib/tst_kconfig.c: add any kconfig with or without expected value function Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 2/4] lib: add any kconfig with or without expected value into kconfig test Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 3/4] lib: add usage that any kconfig with or without expected value in document Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 4/4] umip_basic_test.c: improve kconfig verification to avoid umip wrong abort case Pengfei Xu
2020-05-25 21:24 ` Petr Vorel
2020-05-26 2:32 ` Pengfei Xu
2020-05-26 9:23 ` Petr Vorel
2020-05-26 9:27 ` Petr Vorel
2020-05-26 10:07 ` Pengfei Xu
2020-05-26 10:11 ` Petr Vorel [this message]
2020-05-26 10:37 ` Pengfei Xu
2020-05-27 1:22 ` Xu, Pengfei
2020-05-27 6:26 ` Petr Vorel
2020-05-27 12:24 ` Xu, Pengfei
2020-01-29 16:19 ` [LTP] [PATCH v5 1/4] lib/tst_kconfig.c: add any kconfig with or without expected value function Cyril Hrubis
2020-01-30 10:00 ` Pengfei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526101133.GA3114075@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox