From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 4/4] umip_basic_test.c: improve kconfig verification to avoid umip wrong abort case
Date: Wed, 27 May 2020 08:26:48 +0200 [thread overview]
Message-ID: <20200527062648.GA11836@dell5510> (raw)
In-Reply-To: <33757536896DC84D9B3811B9D9F1A5D13D8BFA2B@SHSMSX101.ccr.corp.intel.com>
Hi Pengfei,
> Seems LINUX_VERSION_CODE way it not suitable when test platform is not compiled platform.
Well, you're expected to have installed kernel headers for target platform, when
you cross compile. That's what embedded distros like buildroot or yocto do.
We already use constructs like this in the code.
> Need to use " if ((tst_kvercmp(5, 5, 0)) >= 0)" way.
As you noticed in previous mail, this will not work, as it's code outside of the
function, so you cannot call any function.
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-27 6:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 9:25 [LTP] [PATCH v5 1/4] lib/tst_kconfig.c: add any kconfig with or without expected value function Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 2/4] lib: add any kconfig with or without expected value into kconfig test Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 3/4] lib: add usage that any kconfig with or without expected value in document Pengfei Xu
2019-12-20 9:25 ` [LTP] [PATCH v5 4/4] umip_basic_test.c: improve kconfig verification to avoid umip wrong abort case Pengfei Xu
2020-05-25 21:24 ` Petr Vorel
2020-05-26 2:32 ` Pengfei Xu
2020-05-26 9:23 ` Petr Vorel
2020-05-26 9:27 ` Petr Vorel
2020-05-26 10:07 ` Pengfei Xu
2020-05-26 10:11 ` Petr Vorel
2020-05-26 10:37 ` Pengfei Xu
2020-05-27 1:22 ` Xu, Pengfei
2020-05-27 6:26 ` Petr Vorel [this message]
2020-05-27 12:24 ` Xu, Pengfei
2020-01-29 16:19 ` [LTP] [PATCH v5 1/4] lib/tst_kconfig.c: add any kconfig with or without expected value function Cyril Hrubis
2020-01-30 10:00 ` Pengfei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527062648.GA11836@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox