From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/2] LVM: Don't require root for generate_lvm_runfile.sh
Date: Thu, 28 May 2020 13:56:36 +0200 [thread overview]
Message-ID: <20200528115636.GB16726@dell5510> (raw)
In-Reply-To: <858875ff-2137-38b6-8301-f44e745f8026@suse.cz>
> On 28. 05. 20 13:05, Petr Vorel wrote:
> > LTPROOT can be in user writable directory. Having rights for make
> > install is user responsibility, it does not have to be guarded by
> > TST_NEEDS_ROOT=1.
> TST_NEEDS_ROOT=1 is there for tst_supported_fs. It won't find any mkfs
> programs if it's not running as root.
Right, thanks for info. Hm, there can be some tests which just want to know
supported filesystems without running them and we have to require root for them.
There could be a solutions (tst_get_supported_fs_types() could have warning
about PATH when user is not root and no mkfs.* found or just changing in
has_mkfs() "mkfs.%s does not exist" to "mkfs.%s does not found" to give more
obvious hint). But it's just a corner case issue, no need to bother with it.
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-28 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 11:05 [LTP] [RFC PATCH 0/2] LVM: Drop legacy scripts and runtest files Petr Vorel
2020-05-28 11:05 ` [LTP] [RFC PATCH 1/2] LVM: Don't require root for generate_lvm_runfile.sh Petr Vorel
2020-05-28 11:39 ` Martin Doucha
2020-05-28 11:56 ` Petr Vorel [this message]
2020-05-28 11:05 ` [LTP] [RFC PATCH 2/2] LVM: Drop legacy scripts and runtest files Petr Vorel
2020-05-28 11:40 ` [LTP] [RFC PATCH 0/2] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528115636.GB16726@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox