[LTP] [PATCH v2 1/4] lib: add new cgroup test API

Li Wang
2020-06-03T12:51:37Z

On Wed, Jun 3, 2020 at 6:43 PM Jan Stancek <jstancek@redhat.com> wrote:

> >> >And the worth to say, the random directory name for same cgroup
> >> >mounting is also on purpose, though we mount same(i.e memory)
> >> >cgroup in two places it still belongs to the one hierarchy, and create
> >> >the same name of the new directory will be hit an error in EEXIST.
> >> >
> >> >static void tst_cgroup_set_path(const char *cgroup_dir)
> >> >{
> >> > ...
> >> > sprintf(tst_cgroup_mnt_path, "%s", cgroup_dir);
> >> > sprintf(tst_cgroup_new_path, "%s/ltp_%d", cgroup_dir, rand());
> >>
> >> I see why you are tracking this in list, but this exchange of state
> through
> >> global variables does seem bit unclear.
> >>
> >
> >Yes, that's a compromise to support more usage of the APIs.
>
> I don't get why global variables are necessary.
>

The only reason to export them as global variables is to make the legacy
read/write_cpuse_files() happy. So that I said it is a compromise.

$ git grep tst_cgroup_new_path
cpuset/cpuset01.c: write_cpuset_files(tst_cgroup_new_path, "cpus",
buf);
cpuset/cpuset01.c: write_cpuset_files(tst_cgroup_new_path, "mems",
mems);
cpuset/cpuset01.c: write_cpuset_files(tst_cgroup_new_path, "mems",
buf);
cpuset/cpuset01.c: write_cpuset_files(tst_cgroup_new_path, "mems",
buf);
lib/mem.c: write_cpuset_files(tst_cgroup_new_path, "mems", buf);
lib/mem.c: write_cpuset_files(tst_cgroup_new_path, "cpus",
cpus);
lib/mem.c: write_cpuset_files(tst_cgroup_new_path, "cpus",
"0");
oom/oom04.c: write_cpuset_files(tst_cgroup_new_path,
"memory_migrate", "1");
oom/oom05.c: write_cpuset_files(tst_cgroup_new_path,
"memory_migrate", "1");

> tst_cgroup_mnt_path is always same as cgroup_dir parameter passed to all
> functions.
> tst_cgroup_get_path() could return pointer to tst_cgroup_pathes->new_path,
> (you just need you call umount before del_path)
> tst_cgroup_ctl_knob is set before each use, so it could be local variable
> too.
>

tst_cgroup_ctl_knob can be localized since no other places need it.

> >I have no strong preference to shift from v2 to this method, or maybe we
> >can try
> >to combine together and do more optimize work in the lib side.
>
> Sounds like we could use 3rd opinion.
>
>

--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200603/e64a2a62/attachment.htm>