[LTP] [PATCH 1/1] tst_taint.h Add taint for randstruct

[LTP] [PATCH 1/1] tst_taint.h Add taint for randstruct

[Petr Vorel]

Added in kernel 4.17.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 include/tst_taint.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/tst_taint.h b/include/tst_taint.h
index 0acc1140c..cfa84dded 100644
--- a/include/tst_taint.h
+++ b/include/tst_taint.h
@@ -60,7 +60,8 @@
 #define TST_TAINT_E     (1 << 13) /* unsigned module was loaded */
 #define TST_TAINT_L     (1 << 14) /* A soft lock-up has previously occurred */
 #define TST_TAINT_K     (1 << 15) /* kernel has been live-patched */
-#define TST_TAINT_X	(1 << 16) /* auxiliary taint, for distro's use */
+#define TST_TAINT_X     (1 << 16) /* auxiliary taint, for distro's use */
+#define TST_TAINT_T     (1 << 17) /* kernel was built with the struct randomization plugin */
 
 /*
  * Initialize and prepare support for checking tainted kernel.
-- 
2.26.2

[LTP] [PATCH 1/1] tst_taint.h Add taint for randstruct

[Jan Stancek]

----- Original Message -----
> Added in kernel 4.17.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  include/tst_taint.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/tst_taint.h b/include/tst_taint.h
> index 0acc1140c..cfa84dded 100644
> --- a/include/tst_taint.h
> +++ b/include/tst_taint.h
> @@ -60,7 +60,8 @@
>  #define TST_TAINT_E     (1 << 13) /* unsigned module was loaded */
>  #define TST_TAINT_L     (1 << 14) /* A soft lock-up has previously occurred
>  */
>  #define TST_TAINT_K     (1 << 15) /* kernel has been live-patched */
> -#define TST_TAINT_X	(1 << 16) /* auxiliary taint, for distro's use */
> +#define TST_TAINT_X     (1 << 16) /* auxiliary taint, for distro's use */
> +#define TST_TAINT_T     (1 << 17) /* kernel was built with the struct
> randomization plugin */

ack, this is trivial enough to push directly

[LTP] [PATCH 1/1] tst_taint.h Add taint for randstruct

[Petr Vorel]

Hi Jan,

> ack, this is trivial enough to push directly

Right, I'm sometimes too careful.
Thanks for your review, Jan, pushed.

Kind regards,
Petr

[LTP] [PATCH 1/1] tst_taint.h Add taint for randstruct

[Petr Vorel]

Hi,

> +++ b/include/tst_taint.h
> @@ -60,7 +60,8 @@
#define TST_TAINT_G     (1 <<  0) /* a module with non-GPL license loaded */

one more note. I'd rename TST_TAINT_G to TST_TAINT_P, it's misleading, we use it
to use it for 'P' (proprietary module loaded).

Also we use taint_flag.c_true, not taint_flag.c_false:
[ TAINT_PROPRIETARY_MODULE ]    = { 'P', 'G', true },

But this flag hasn't been used, it might be always as placeholder (never
actually needed).

Kind regards,
Petr