From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib
Date: Wed, 10 Jun 2020 11:51:25 +0200 [thread overview]
Message-ID: <20200610095125.GA21406@dell5510> (raw)
In-Reply-To: <2845dc64-cce0-47df-1005-4cc508bd9388@cn.fujitsu.com>
Hi Xu,
> > I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).
> Yes.
> > Maybe removing libdir could be in separate commit, it looks to me as unrelated
> > change.
Actually, when looking into this more (this part is new in v2, Jan didn't review
it).
I'd keep keep libdir in include/mk/config.mk.in, because we use it in our
lib/ltp.pc file. Maybe we don't need if we don't install any library, but then
we should remove also LIB variable and associated code in include/mk/lib.mk.
Which should be a second step (second commit).
Also libdir is somehow expected by automake (it's referenced in generated
./m4/Makefile.in ./testcases/realtime/m4/Makefile.in).
Kind regards,
Petr
next prev parent reply other threads:[~2020-06-10 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57a1c19e-d8e5-4389-8565-20e49f144657@G08CNEXMBPEKD05.g08.fujitsu.local>
2020-06-10 1:28 ` [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib Yang Xu
2020-06-10 8:05 ` Petr Vorel
2020-06-10 8:21 ` Yang Xu
2020-06-10 9:51 ` Petr Vorel [this message]
2020-06-10 8:47 ` Xiao Yang
2020-06-10 10:48 ` Petr Vorel
2020-06-02 7:37 Yang Xu
2020-06-08 10:10 ` Petr Vorel
2020-06-08 11:01 ` Yang Xu
2020-06-08 11:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610095125.GA21406@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox