From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH] lapi: Add posix_types.h
Date: Tue, 16 Jun 2020 21:44:29 +0200 [thread overview]
Message-ID: <20200616194429.GA31700@yuki.lan> (raw)
In-Reply-To: <20200616190918.24761-1-pvorel@suse.cz>
Hi!
> To fix undefined __kernel_ulong_t, which was defined in v3.4-rc1
> in afead38d011a ("posix_types: Introduce __kernel_[u]long_t").
>
> This fixed build error:
>
> In file included from /usr/src/ltp/include/lapi/msgbuf.h:13,
> from /usr/src/ltp/testcases/kernel/syscalls/ipc/msgctl/msgctl05.c:9:
> /usr/src/ltp/include/lapi/ipcbuf.h: At top level:
> /usr/src/ltp/include/lapi/ipcbuf.h:187: error: expected specifier-qualifier-list before '__kernel_ulong_t'
>
> Fixes: 3e1fc0644 ("include: Add declaration of struct ipc64_perm")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>
> or is it a time to drop that support?
> If I remember we were talking about 3.0, this is 3.4.
>
> Is this correct?
> +#ifndef __kernel_long_t
> +# if defined(__x86_64__) && defined(__ILP32__)
> +typedef long long __kernel_long_t;
> +typedef unsigned long long __kernel_ulong_t;
> +# else
> +typedef long __kernel_long_t;
> +typedef unsigned long __kernel_ulong_t;
> +# endif
> +#endif
As far as I can tell yes, I came to the same conclusion.
I guess that we may as well push this patch since you already put an
effort into crafting it.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-06-16 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 19:09 [LTP] [RFC PATCH] lapi: Add posix_types.h Petr Vorel
2020-06-16 19:44 ` Cyril Hrubis [this message]
2020-06-17 4:51 ` Viresh Kumar
2020-06-17 10:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616194429.GA31700@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox