public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] network/nsf_lib.sh: TCONF on mount (udp/udp6) failure for Linux v5.6+
Date: Thu, 18 Jun 2020 11:36:46 +0200	[thread overview]
Message-ID: <20200618093646.GA11962@dell5510> (raw)
In-Reply-To: <20200618055105.GA42990@x230>

Hi Li, Alexey, Cyril,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> > > @@ -87,11 +87,17 @@ nfs_mount()

> > >         tst_res TINFO "Mounting NFS: $mnt_cmd"
> > >         if [ -n "$LTP_NETNS" ] && [ -z "$LTP_NFS_NETNS_USE_LO" ]; then
> > > -               tst_rhost_run -s -c "$mnt_cmd"


> > Or, maybe we can have a new function naming as 'tst_kconifg_check' to parse
> > kernel .config in shell library as well?
> +1, I was thinking about it for a long time.
Thinking about the balance between base TCONF decision on kernel version vs.
require kernel config to be presented I think for cases like this I'd prefer
kernel version based check (i.e. the original patch).

Requiring kernel config is ok for traditional distros (and even here is
sometimes readable only for root, e.g. Debian/Ubuntu), but it's still rare on
arm (other embedded archs). I guess it'd be nice to have some variable, which
would turn kernel config based requirement into warning.

Kind regards,
Petr

  reply	other threads:[~2020-06-18  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 15:49 [LTP] [PATCH] network/nsf_lib.sh: TCONF on mount (udp/udp6) failure for Linux v5.6+ Alexey Kodanev
2020-06-18  3:15 ` Li Wang
2020-06-18  5:51   ` Petr Vorel
2020-06-18  9:36     ` Petr Vorel [this message]
2020-06-18 13:24       ` Alexey Kodanev
2020-06-18 13:49         ` Petr Vorel
2020-06-19  2:56           ` Li Wang
2020-06-22 13:34           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618093646.GA11962@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox