From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Thu, 18 Jun 2020 11:36:46 +0200 Subject: [LTP] [PATCH] network/nsf_lib.sh: TCONF on mount (udp/udp6) failure for Linux v5.6+ In-Reply-To: <20200618055105.GA42990@x230> References: <20200617154926.32588-1-alexey.kodanev@oracle.com> <20200618055105.GA42990@x230> Message-ID: <20200618093646.GA11962@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Li, Alexey, Cyril, Reviewed-by: Petr Vorel > > > +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh > > > @@ -87,11 +87,17 @@ nfs_mount() > > > tst_res TINFO "Mounting NFS: $mnt_cmd" > > > if [ -n "$LTP_NETNS" ] && [ -z "$LTP_NFS_NETNS_USE_LO" ]; then > > > - tst_rhost_run -s -c "$mnt_cmd" > > Or, maybe we can have a new function naming as 'tst_kconifg_check' to parse > > kernel .config in shell library as well? > +1, I was thinking about it for a long time. Thinking about the balance between base TCONF decision on kernel version vs. require kernel config to be presented I think for cases like this I'd prefer kernel version based check (i.e. the original patch). Requiring kernel config is ok for traditional distros (and even here is sometimes readable only for root, e.g. Debian/Ubuntu), but it's still rare on arm (other embedded archs). I guess it'd be nice to have some variable, which would turn kernel config based requirement into warning. Kind regards, Petr