From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lapi/io_uring.h: Add declaration of __kernel_rwf_t
Date: Fri, 17 Jul 2020 10:08:40 +0200 [thread overview]
Message-ID: <20200717080840.GB32407@dell5510> (raw)
In-Reply-To: <20200717073842.GA31254@dell5510>
> > Since kernel commit ddef7ed2b5cb ("annotate RWF_... flags"), fs.h introduced
> > __kernel_rwf_t data type in 4.14-rc1.
> >
> > Fix build error on old kernel.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Thanks for the fix.
> Going to merge it, just wait for travis verification.
BTW the regression was caused by my changes to the lapi header in 95399bc87
("lapi/io_uring: Preparation for io_uring tests") - I updated the header.
We might consider not including <linux/types.h>, it's needed just for
__kernel_rwf_t. I'm against these optimisations (as the definition can change),
but I remember Jan asked me to avoid including kernel header just for single use
[1], but maybe this is a different case.
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/ltp/patch/20191016211501.3777-1-petr.vorel@gmail.com/#2281586
next prev parent reply other threads:[~2020-07-17 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 4:13 [LTP] [PATCH] lapi/io_uring.h: Add declaration of __kernel_rwf_t Yang Xu
2020-07-17 7:38 ` Petr Vorel
2020-07-17 8:08 ` Petr Vorel [this message]
2020-07-17 10:32 ` Yang Xu
2020-07-17 10:38 ` Cyril Hrubis
2020-07-17 11:04 ` Petr Vorel
2020-07-17 11:29 ` Petr Vorel
2020-07-19 17:26 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717080840.GB32407@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox