From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] libs: sigwait: Get rid of REPORT_SUCCESS() macro
Date: Fri, 24 Jul 2020 07:58:26 +0200 [thread overview]
Message-ID: <20200724055826.GE32086@dell5510> (raw)
In-Reply-To: <a83166af3a2b432bb11a0876e18e15705479f32d.1595511710.git.viresh.kumar@linaro.org>
Hi Viresh,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Although these errors are still here:
sigwait.c: In function ?test_masked_matching?:
sigwait.c:157:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
157 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ?TEST?
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ?test_masked_matching_rt?:
sigwait.c:226:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
226 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ?TEST?
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ?test_masked_matching_noinfo?:
sigwait.c:265:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
265 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ?TEST?
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ?test_bad_address?:
sigwait.c:312:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
312 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
IMHO we shouldn't use oldmask for src and dest.
Kind regards,
Petr
next prev parent reply other threads:[~2020-07-24 5:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:42 [LTP] [PATCH 1/4] libs: sigwait: Use SAFE_FORK() Viresh Kumar
2020-07-23 13:42 ` [LTP] [PATCH 2/4] libs: sigwait: Add SAFE_SIG*() macros Viresh Kumar
2020-07-24 5:51 ` Petr Vorel
2020-07-24 8:43 ` Cyril Hrubis
2020-07-23 13:42 ` [LTP] [PATCH 3/4] libs: sigwait: Remove alarm() from setup() and cleanup() Viresh Kumar
2020-07-24 5:52 ` Petr Vorel
2020-07-24 8:44 ` Cyril Hrubis
2020-07-23 13:42 ` [LTP] [PATCH 4/4] libs: sigwait: Get rid of REPORT_SUCCESS() macro Viresh Kumar
2020-07-24 5:58 ` Petr Vorel [this message]
2020-07-24 10:34 ` Viresh Kumar
2020-07-24 12:20 ` Cyril Hrubis
2020-07-24 13:37 ` Petr Vorel
2020-07-24 12:32 ` Cyril Hrubis
2020-07-24 13:35 ` Petr Vorel
2020-07-24 5:49 ` [LTP] [PATCH 1/4] libs: sigwait: Use SAFE_FORK() Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724055826.GE32086@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox