From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <pvorel@suse.cz>
Date: Fri, 24 Jul 2020 15:32:47 +0200
Subject: [LTP] [PATCH v2 2/2] Add chdir() test for unprivileged user
In-Reply-To: <20200724125052.20973-2-mdoucha@suse.cz>
References: <20200724125052.20973-1-mdoucha@suse.cz>
 <20200724125052.20973-2-mdoucha@suse.cz>
Message-ID: <20200724133247.GC24626@dell5510>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi Martin,

> +++ b/runtest/syscalls
> @@ -54,6 +54,7 @@ capset04 capset04
>  cacheflush01 cacheflush01

>  chdir01 chdir01
> +chdir02 chdir02
>  chdir01A symlink01 -T chdir01
>  chdir04 chdir04
You missed to add chdir02 to runtest/quickhit. I guess this was deliberate,
right?
(I wonder if we really need runtest/quickhit anyway).

I like both tests (nice work, thanks!), just don't like the duplicity. Isn't
there a way to use getopt parameter for one of the variants and have just single
test? But understand if you don't bother with it (maybe better duplicity but
simpler code).

Other that that LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr