From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V7 17/19] syscalls/utimensat: Migrate to new test framework
Date: Mon, 27 Jul 2020 17:35:01 +0200 [thread overview]
Message-ID: <20200727153501.GD7863@yuki.lan> (raw)
In-Reply-To: <f0df00dd69cf02791a99883db1fd6fd7a1462074.1593152309.git.viresh.kumar@linaro.org>
Hi!
> This gets rid of the test script and updates the utimensat01.c file to
> handle most of the tests covered earlier (apart from testing the same
> for files owned by root, as the test is run as root right now).
We also lost a check if atime and mtime was modified or not.
The original script did set both to 0 and then depending on what have
been passed as the times and if the call succeeded checked if the value
stayed zero or was modified. Can we add this back as well?
Also the modification for the makefile and runtest file is part of the
patch that adds the time64 variant while it should have been part of
this patch.
Other than this there are a few minor things, for instance I do not see
the reason for double indirection in the struct mytime. And I would have
done some of the initialization in the test setup, e.g. why do we call
update_error(), re-create TEST_DIR, etc. on each run.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-07-27 15:35 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 6:22 [LTP] [PATCH V7 00/19] Syscalls: Add support for time64 variants Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 01/19] tst_timer: Add new definitions Viresh Kumar
2020-06-26 9:49 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 02/19] syscalls/timer_gettime: Add support for time64 tests Viresh Kumar
2020-06-26 9:49 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 03/19] syscalls/timer_settime: " Viresh Kumar
2020-06-29 9:39 ` Cyril Hrubis
2020-06-29 11:43 ` Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 04/19] syscalls/timerfd: " Viresh Kumar
2020-07-02 12:24 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 05/19] syscalls/sched_rr_get_interval: " Viresh Kumar
2020-07-02 13:06 ` Cyril Hrubis
2020-07-03 3:15 ` Viresh Kumar
2020-07-03 5:52 ` Yang Xu
2020-07-03 7:26 ` Viresh Kumar
2020-07-03 7:38 ` [LTP] [PATCH] syscalls/sched_rr_get_interval: Validate the timeslice Viresh Kumar
2020-07-03 7:43 ` Yang Xu
2020-07-03 7:51 ` Viresh Kumar
2020-07-03 8:00 ` Yang Xu
2020-07-03 8:18 ` Viresh Kumar
2020-07-03 9:01 ` Yang Xu
2020-07-03 14:08 ` Cyril Hrubis
2020-07-06 3:31 ` [LTP] [PATCH V2] " Viresh Kumar
2020-07-06 4:41 ` Yang Xu
2020-07-07 9:30 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 06/19] syscalls/futex: Merge futex_wait_bitset tests Viresh Kumar
2020-07-03 9:15 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 07/19] syscalls/futex: Add support for time64 tests Viresh Kumar
2020-07-03 12:45 ` Cyril Hrubis
2020-07-06 10:40 ` Viresh Kumar
2020-07-06 11:36 ` Viresh Kumar
2020-07-06 11:40 ` [LTP] [PATCH V7.1 " Viresh Kumar
2020-07-23 19:44 ` Cyril Hrubis
2020-07-24 2:33 ` Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 08/19] syscalls/io_pgetevents: " Viresh Kumar
2020-07-03 14:59 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 09/19] syscalls/sigwaitinfo: Migrate to new test framework Viresh Kumar
2020-07-03 13:58 ` Cyril Hrubis
2020-07-06 2:39 ` Viresh Kumar
2020-07-07 15:16 ` Cyril Hrubis
2020-07-09 10:46 ` Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 10/19] syscalls/rt_sigtimedwait: Add support for time64 tests Viresh Kumar
2020-07-22 10:03 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 11/19] syscalls/mq_timed{send|receive}: " Viresh Kumar
2020-07-24 14:51 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 12/19] syscalls/recvmmsg: " Viresh Kumar
2020-07-24 15:13 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 13/19] syscalls/ppoll: " Viresh Kumar
2020-07-27 9:17 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 14/19] syscalls/select6: " Viresh Kumar
2020-07-27 9:40 ` Cyril Hrubis
2020-07-28 7:23 ` Viresh Kumar
2020-07-28 8:02 ` Arnd Bergmann
2020-06-26 6:22 ` [LTP] [PATCH V7 15/19] syscalls/semop: Migrate to new test framework Viresh Kumar
2020-07-27 13:46 ` Cyril Hrubis
2020-06-26 6:22 ` [LTP] [PATCH V7 16/19] syscalls/semtimedop: Add support for semtimedop and its time64 version Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 17/19] syscalls/utimensat: Migrate to new test framework Viresh Kumar
2020-07-27 15:35 ` Cyril Hrubis [this message]
2020-06-26 6:22 ` [LTP] [PATCH V7 18/19] syscalls/utimensat: Add support for time64 tests Viresh Kumar
2020-06-26 6:22 ` [LTP] [PATCH V7 19/19] syscalls: clock_settime: Add test around y2038 vulnerability Viresh Kumar
2020-07-28 12:11 ` Cyril Hrubis
2020-08-04 12:37 ` Viresh Kumar
2020-07-20 10:19 ` [LTP] [PATCH V7 00/19] Syscalls: Add support for time64 variants Viresh Kumar
2020-07-22 10:04 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727153501.GD7863@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox