From: Erico Nunes <ernunes@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] lib: add function to check for kernel lockdown
Date: Tue, 28 Jul 2020 18:22:05 +0200 [thread overview]
Message-ID: <20200728162207.332109-1-ernunes@redhat.com> (raw)
Some syscalls are not available if the kernel is booted using the
'lockdown' feature. That can cause some tests to report fail, showing
a message like:
Lockdown: iopl01: iopl is restricted; see man kernel_lockdown.7
This patch adds a function that can be used by tests to check for this
case, so it can be handled accordingly.
Signed-off-by: Erico Nunes <ernunes@redhat.com>
---
v2:
- just return the lockdown status so tests can handle as needed, instead
of just always skipping the test.
- handle fgets return value to avoid compiler warning (can't return any
sensible value so I just ported what I have seen in other similar
cases).
---
include/tst_lockdown.h | 8 ++++++++
include/tst_test.h | 1 +
lib/tst_lockdown.c | 31 +++++++++++++++++++++++++++++++
3 files changed, 40 insertions(+)
create mode 100644 include/tst_lockdown.h
create mode 100644 lib/tst_lockdown.c
diff --git a/include/tst_lockdown.h b/include/tst_lockdown.h
new file mode 100644
index 000000000..383026b1e
--- /dev/null
+++ b/include/tst_lockdown.h
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#ifndef TST_LOCKDOWN_H
+#define TST_LOCKDOWN_H
+
+int tst_lockdown_enabled(void);
+
+#endif /* TST_LOCKDOWN_H */
diff --git a/include/tst_test.h b/include/tst_test.h
index b84f7b9dd..b02de4597 100644
--- a/include/tst_test.h
+++ b/include/tst_test.h
@@ -40,6 +40,7 @@
#include "tst_hugepage.h"
#include "tst_assert.h"
#include "tst_cgroup.h"
+#include "tst_lockdown.h"
/*
* Reports testcase result.
diff --git a/lib/tst_lockdown.c b/lib/tst_lockdown.c
new file mode 100644
index 000000000..024047aae
--- /dev/null
+++ b/lib/tst_lockdown.c
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#define TST_NO_DEFAULT_MAIN
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <sys/mount.h>
+
+#include "tst_test.h"
+#include "tst_safe_macros.h"
+#include "tst_safe_stdio.h"
+#include "tst_lockdown.h"
+
+int tst_lockdown_enabled(void)
+{
+ char line[BUFSIZ];
+ const char *lockdown_path = "/sys/kernel/security/lockdown";
+ FILE *file;
+
+ if (access("/sys/kernel/security/lockdown", F_OK) != 0) {
+ tst_res(TINFO, "Unable to determine system lockdown state\n");
+ return 0;
+ }
+
+ file = SAFE_FOPEN(lockdown_path, "r");
+ if (!fgets(line, sizeof(line), file))
+ tst_brk(TBROK | TERRNO, "fgets %s", lockdown_path);
+ SAFE_FCLOSE(file);
+
+ return (strstr(line, "[none]") == NULL);
+}
--
2.26.2
next reply other threads:[~2020-07-28 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 16:22 Erico Nunes [this message]
2020-07-28 16:22 ` [LTP] [PATCH v2 2/3] ioperm01: skip test if kernel is locked down Erico Nunes
2020-07-28 16:22 ` [LTP] [PATCH v2 3/3] iopl01: " Erico Nunes
2020-07-29 3:14 ` [LTP] [PATCH v2 1/3] lib: add function to check for kernel lockdown Li Wang
2020-07-29 6:33 ` Cyril Hrubis
2020-07-30 0:21 ` Li Wang
2020-07-29 10:55 ` Erico Nunes
2020-07-29 12:07 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728162207.332109-1-ernunes@redhat.com \
--to=ernunes@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox