From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] syscalls/ioctl_loop06: Using LOOP_CONFIGURE to test invalid block size
Date: Wed, 29 Jul 2020 12:07:58 +0200 [thread overview]
Message-ID: <20200729100758.GA7152@yuki.lan> (raw)
In-Reply-To: <1595556357-29932-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi!
> static void verify_ioctl_loop(unsigned int n)
> +{
> + if (tcases[n].ioctl_flag == LOOP_CONFIGURE)
> + TEST(ioctl(dev_fd, LOOP_CONFIGURE, &loopconfig));
> + else
> + TEST(ioctl(dev_fd, LOOP_SET_BLOCK_SIZE, *(tcases[n].setvalue)));
> +
> + if (TST_RET == 0) {
> + tst_res(TFAIL, "Set block size succeed unexpectedly");
> + if (tcases[n].ioctl_flag == LOOP_CONFIGURE)
> + TST_RETRY_FUNC(ioctl(dev_fd, LOOP_CLR_FD, 0), TST_RETVAL_EQ0);
I guess that we can use the tst_detach_device_by_fd() here as well
right?
If you agree with that change I will change this and push the patch.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-07-29 10:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:35 [LTP] [PATCH v1 0/4] *** Add LOOP_CONFIGURE ioctl test *** Yang Xu
2020-06-11 10:35 ` [LTP] [PATCH v1 1/4] lapi: Add fallback for LOOP_CONFIGURE ioctl and struct loop_config Yang Xu
2020-07-08 13:18 ` Cyril Hrubis
2020-06-11 10:35 ` [LTP] [PATCH v1 2/4] syscalls/ioctl_loop02: Using LOOP_CONFIGURE to set read_only Yang Xu
2020-07-08 13:15 ` Cyril Hrubis
2020-06-11 10:35 ` [LTP] [PATCH v1 3/4] syscalls/ioctl_loop08: Add LOOP_CONFIGURE error test with invalid block size Yang Xu
2020-07-08 14:00 ` Cyril Hrubis
2020-06-11 10:35 ` [LTP] [PATCH v1 4/4] syscalls/ioctl_loop09: Add LOOP_CONFIGURE ioctl test with direct I/O flag Yang Xu
2020-07-08 14:00 ` Cyril Hrubis
2020-07-10 6:39 ` [LTP] [PATCH v2 1/2] syscalls/ioctl_loop06: Using LOOP_CONFIGURE to test invalid block size Yang Xu
2020-07-10 6:39 ` [LTP] [PATCH v2 2/2] syscalls/ioctl_loop05: Using LOOP_CONFIGURE to set direct io Yang Xu
2020-07-30 7:28 ` Yang Xu
2020-07-22 9:45 ` [LTP] [PATCH v2 1/2] syscalls/ioctl_loop06: Using LOOP_CONFIGURE to test invalid block size Cyril Hrubis
2020-07-22 10:15 ` Yang Xu
2020-07-22 12:59 ` Cyril Hrubis
2020-07-23 9:41 ` Yang Xu
2020-07-24 2:05 ` [LTP] [PATCH v3 " Yang Xu
2020-07-24 2:05 ` [LTP] [PATCH v3 2/2] syscalls/ioctl_loop05: Using LOOP_CONFIGURE to set direct io Yang Xu
2020-07-29 11:39 ` Cyril Hrubis
2020-07-30 8:49 ` Yang Xu
2020-07-30 9:28 ` Cyril Hrubis
2020-07-30 10:08 ` Yang Xu
2020-07-30 10:38 ` Cyril Hrubis
2020-07-29 12:58 ` Cyril Hrubis
2020-07-29 10:07 ` Cyril Hrubis [this message]
2020-07-29 10:43 ` [LTP] [PATCH v3 1/2] syscalls/ioctl_loop06: Using LOOP_CONFIGURE to test invalid block size Yang Xu
2020-07-31 14:15 ` Cyril Hrubis
2020-07-06 1:45 ` [LTP] [PATCH v1 0/4] *** Add LOOP_CONFIGURE ioctl test *** Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729100758.GA7152@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox