From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] semctl: Fix 32 bit build
Date: Thu, 30 Jul 2020 11:48:42 +0200 [thread overview]
Message-ID: <20200730094842.GB3457@yuki.lan> (raw)
In-Reply-To: <20200730092637.487-1-pvorel@suse.cz>
Hi!
> testcases/kernel/syscalls/ipc/semctl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ipc/semctl/Makefile b/testcases/kernel/syscalls/ipc/semctl/Makefile
> index 99971a7db..2559b4c28 100644
> --- a/testcases/kernel/syscalls/ipc/semctl/Makefile
> +++ b/testcases/kernel/syscalls/ipc/semctl/Makefile
> @@ -8,6 +8,6 @@ LTPLIBS = ltpipc ltpnewipc
> include $(top_srcdir)/include/mk/testcases.mk
>
> semctl01 semctl02 semctl03 semctl04 semctl05 semctl06 semctl07: LDLIBS += -lltpipc
> -semctl08: LDLIBS += -lltpnewipc
> +semctl08: LDLIBS = -lltpnewipc -lltp
If nothing else this may break things if user passed something in
LDLIBS, so it should be:
LDLIBS = -lltpnewipc $(LDLIBS)
And I guess the safest rule would be to add the -lltp* libraries first,
because naturally none of the code in LTP but the test depends on these.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-07-30 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:26 [LTP] [PATCH 1/1] semctl: Fix 32 bit build Petr Vorel
2020-07-30 9:48 ` Cyril Hrubis [this message]
2020-07-30 10:16 ` Petr Vorel
2020-07-30 12:22 ` Cyril Hrubis
2020-07-30 12:53 ` Petr Vorel
2020-07-30 14:09 ` Cyril Hrubis
2020-07-30 16:13 ` Petr Vorel
2020-07-31 10:55 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730094842.GB3457@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox