From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2 2/2] libs: sigwait: Get rid of REPORT_SUCCESS() macro
Date: Thu, 30 Jul 2020 17:25:05 +0200 [thread overview]
Message-ID: <20200730152505.GF3457@yuki.lan> (raw)
In-Reply-To: <20200729151317.evk2cphq7tclcww5@vireshk-mac-ubuntu>
Hi!
> > Unfortunately half of this patch does not apply after the changes in the
> > first one, can you please rebase?
>
> I didn't see any issues with normal rebase of this patch over the other one, git
> probably resolved issues itself.
Well the original v2 patch contains references to the sigprocmask()
lines that the previous patch changes, what I got bunch of these:
Checking patch libs/libltpsigwait/sigwait.c...
error: while searching for:
child = create_sig_proc(signo, 1, 0);
TEST(sigwaitinfo(&sigs, &si, NULL));
REPORT_SUCCESS_COND(signo, 0, si.si_pid == child
&& si.si_code == SI_USER
&& si.si_signo == signo, "Struct siginfo mismatch");
TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask));
if (TST_RET == -1)
Because the sigprocmask(SIG_SETMASK, &sigs, &oldmask)); couldn't be found.
The patch that you resend has corrected these.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-07-30 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:40 [LTP] [PATCH V2 1/2] libs: sigwait: Fix compilation warning around sigprocmask() Viresh Kumar
2020-07-27 9:40 ` [LTP] [PATCH V2 2/2] libs: sigwait: Get rid of REPORT_SUCCESS() macro Viresh Kumar
2020-07-29 14:40 ` Cyril Hrubis
2020-07-29 15:13 ` Viresh Kumar
2020-07-30 15:25 ` Cyril Hrubis [this message]
2020-07-28 13:02 ` [LTP] [PATCH V2 1/2] libs: sigwait: Fix compilation warning around sigprocmask() Cyril Hrubis
2020-07-29 12:55 ` [LTP] [PATCH V3 " Viresh Kumar
2020-07-29 14:39 ` Cyril Hrubis
2020-07-29 15:13 ` [LTP] [PATCH V2 resend 2/2] libs: sigwait: Get rid of REPORT_SUCCESS() macro Viresh Kumar
2020-07-30 15:34 ` Cyril Hrubis
2020-08-04 7:57 ` [LTP] [PATCH V3 " Viresh Kumar
2020-08-06 12:26 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730152505.GF3457@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox