public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] prepare_lvm.sh: Allow to define tmp directory
Date: Mon, 24 Aug 2020 17:48:12 +0200	[thread overview]
Message-ID: <20200824154812.GA4330@dell5510> (raw)
In-Reply-To: <648dc99d-5079-23ec-eba2-b10215ae8130@suse.cz>

Hi Martin,

...
> > -			sed -e "s/{fsname}/$fsname/g" "$INFILE" >>"$OUTFILE"
> > +			sed -e "s/{fsname}/$fsname/g; s^/tmp/ltp^$LVM_DIR/ltp^g" "$INFILE" >>"$OUTFILE"

> If you want to change the path in the runfile instead, it'd be cleaner
> to use a placeholder like {tempdir}. Otherwise:
That makes sense, changed that way and merged with your ack.
Thanks a lot for review and comments.

Kind regards,
Petr

      reply	other threads:[~2020-08-24 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 11:21 [LTP] [PATCH v2 1/1] prepare_lvm.sh: Allow to define tmp directory Petr Vorel
2020-08-24 14:28 ` Martin Doucha
2020-08-24 15:48   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824154812.GA4330@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox