From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 7/9] syscalls/ipc: Add shmctl07 test
Date: Mon, 7 Sep 2020 16:45:29 +0200 [thread overview]
Message-ID: <20200907144529.GB10649@yuki.lan> (raw)
In-Reply-To: <CAEemH2dJhxobkJtemb8sxx0cc9gfmVc+fq=ZNE0LfKWTdiMuoA@mail.gmail.com>
Hi!
> Shouldn't we do update 'ds' before checking the ds.shm_perm.mode?
>
> --- a/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c
> +++ b/testcases/kernel/syscalls/ipc/shmctl/shmctl07.c
> @@ -42,10 +42,11 @@ static void verify_shmlock(void)
> else
> tst_res(TPASS, "shmctl(%i, SHM_UNLOCK, NULL)", shm_id);
>
> + SAFE_SHMCTL(shm_id, IPC_STAT, &ds);
> if (ds.shm_perm.mode & SHM_LOCKED)
> - tst_res(TPASS, "SHM_LOCKED bit is off in shm_perm.mode");
> - else
> tst_res(TFAIL, "SMH_LOCKED bit is on in shm_perm.mode");
> + else
> + tst_res(TPASS, "SHM_LOCKED bit is off in shm_perm.mode");
> }
>
>
>
> > + if (ds.shm_perm.mode & SHM_LOCKED)
> > + tst_res(TPASS, "SHM_LOCKED bit is off in shm_perm.mode");
> >
>
> And in this branch, the status should be "on" but not "off".
And also TFAIL.
All will be fixed in v2, thx for the review.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-09-07 14:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 16:34 [LTP] [PATCH 0/9] Rewrite shmctl() testcases Cyril Hrubis
2020-07-17 16:34 ` [LTP] [PATCH 1/9] syscalls/ipc: shmctl02: Convert to the new library Cyril Hrubis
2020-07-19 2:51 ` Li Wang
2020-07-21 14:32 ` Martin Doucha
2020-07-17 16:34 ` [LTP] [PATCH 2/9] syscalls/ipc: shmctl03: Remove Cyril Hrubis
2020-07-17 16:34 ` [LTP] [PATCH 3/9] syscalls/ipc: shmctl04: Rewrite from scratch Cyril Hrubis
2020-07-19 7:48 ` Li Wang
2020-09-07 11:16 ` Cyril Hrubis
2020-07-28 9:16 ` Petr Vorel
2020-07-17 16:34 ` [LTP] [PATCH 4/9] syscalls/ipc: shmctl05 remove lib dependency Cyril Hrubis
2020-07-17 16:34 ` [LTP] [PATCH 5/9] lib/tst_assert: Add TST_ASSERT_ULONG() Cyril Hrubis
2020-07-17 16:34 ` [LTP] [PATCH 6/9] syscalls/ipc: Add shmctl() IPC_INFO test Cyril Hrubis
2020-07-19 9:36 ` Li Wang
2020-07-21 16:03 ` Martin Doucha
2020-07-17 16:34 ` [LTP] [PATCH 7/9] syscalls/ipc: Add shmctl07 test Cyril Hrubis
2020-07-19 9:50 ` Li Wang
2020-09-07 14:45 ` Cyril Hrubis [this message]
2020-07-17 16:34 ` [LTP] [PATCH 8/9] syscalls/ipc: Add shmctl IPC_SET test Cyril Hrubis
2020-07-20 2:26 ` Li Wang
2020-09-07 14:47 ` Cyril Hrubis
2020-07-22 10:35 ` Martin Doucha
2020-07-17 16:34 ` [LTP] [PATCH 9/9] syscalls/ipc: Rewrite shmctl01 Cyril Hrubis
2020-07-22 14:50 ` Martin Doucha
2020-07-20 7:14 ` [LTP] [PATCH 0/9] Rewrite shmctl() testcases Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907144529.GB10649@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox