From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] fanotify10: Skip non zero ignored_onchild tests for < v5.9
Date: Fri, 11 Sep 2020 11:33:29 +0200 [thread overview]
Message-ID: <20200911093329.GA7459@dell5510> (raw)
In-Reply-To: <CAOQ4uxjUj35ePAzQuEO6BrTskrrp0TLX-tnV7L4Opcda0Mm8gg@mail.gmail.com>
Hi Amir,
> On Fri, Sep 11, 2020 at 9:51 AM Petr Vorel <pvorel@suse.cz> wrote:
> > ignored mask in combination with flag FAN_EVENT_ON_CHILD has
> > undefined behavior on kernel < 5.9.
> > Also remove wrong kernel commit (left in e8189ff3c).
> > Acked-by: Jan Kara <jack@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Thanks!
...
> > - * Test cases #17-#23 are regression tests for commit:
> > + * Test cases #17-#23 are regression tests for commit (from v5.9, unlikely to be
> > + * backported thus not in .tags):
> If we are being accurate, it is only the 4 test cases with non zero
> ignored_onchild
> that are regression tests for this commit. The other 3 test cases are
> just completing
> the test matrix of possible combinations of marks.
> So you may rephrase above as "Test cases with 'ignored_onchild'..."
> or what not.
Good point, I'll fix it before merge.
Kind regards,
Petr
prev parent reply other threads:[~2020-09-11 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 6:51 [LTP] [PATCH v2 1/1] fanotify10: Skip non zero ignored_onchild tests for < v5.9 Petr Vorel
2020-09-11 7:38 ` Amir Goldstein
2020-09-11 9:33 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911093329.GA7459@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox