[LTP] [PATCH] Fix top_srcdir handling in numa/sound test Makefiles

[LTP] [PATCH] Fix top_srcdir handling in numa/sound test Makefiles

[Martin Doucha]

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
 testcases/kernel/numa/Makefile  | 18 ++----------------
 testcases/kernel/sound/Makefile |  2 +-
 2 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/testcases/kernel/numa/Makefile b/testcases/kernel/numa/Makefile
index 48494e456..2c6a7c6a1 100644
--- a/testcases/kernel/numa/Makefile
+++ b/testcases/kernel/numa/Makefile
@@ -1,22 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
 #
 #  Copyright (c) International Business Machines  Corp., 2007
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
 
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
diff --git a/testcases/kernel/sound/Makefile b/testcases/kernel/sound/Makefile
index 022e69197..5c728ef36 100644
--- a/testcases/kernel/sound/Makefile
+++ b/testcases/kernel/sound/Makefile
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
-- 
2.28.0

[LTP] [PATCH] Fix top_srcdir handling in numa/sound test Makefiles

[Cyril Hrubis]

Hi!
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>  testcases/kernel/numa/Makefile  | 18 ++----------------
>  testcases/kernel/sound/Makefile |  2 +-
>  2 files changed, 3 insertions(+), 17 deletions(-)
> 
> diff --git a/testcases/kernel/numa/Makefile b/testcases/kernel/numa/Makefile
> index 48494e456..2c6a7c6a1 100644
> --- a/testcases/kernel/numa/Makefile
> +++ b/testcases/kernel/numa/Makefile
> @@ -1,22 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
>  #
>  #  Copyright (c) International Business Machines  Corp., 2007
> -#
> -#  This program is free software;  you can redistribute it and/or modify
> -#  it under the terms of the GNU General Public License as published by
> -#  the Free Software Foundation; either version 2 of the License, or
> -#  (at your option) any later version.
> -#
> -#  This program is distributed in the hope that it will be useful,
> -#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
> -#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> -#  the GNU General Public License for more details.
> -#
> -#  You should have received a copy of the GNU General Public License
> -#  along with this program;  if not, write to the Free Software
> -#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> -#

Well technically unrealted changes should be divided into a separate
patches so that in a case of revert we do not have to revert everything
but only the offending change...

> -top_srcdir		:= ../../..
> +top_srcdir		?= ../../..
>  
>  include $(top_srcdir)/include/mk/testcases.mk
>  
> diff --git a/testcases/kernel/sound/Makefile b/testcases/kernel/sound/Makefile
> index 022e69197..5c728ef36 100644
> --- a/testcases/kernel/sound/Makefile
> +++ b/testcases/kernel/sound/Makefile
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  
> -top_srcdir		:= ../../..
> +top_srcdir		?= ../../..
>  
>  include $(top_srcdir)/include/mk/testcases.mk
>  
> -- 
> 2.28.0
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz