ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
* [LTP] [PATCH 1/1] recvmmsg01: Fix compilation
@ 2020-09-23  9:46 Petr Vorel
  2020-09-23  9:50 ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2020-09-23  9:46 UTC (permalink / raw)
  To: ltp

void* cannot be directly used, it must be pointing to the struct.

recvmmsg01.c:86:9: error: request for member ?type? in something not a
structure or union
  timeout.type = tv->ts_type;

Fixes: 135af8ede ("syscalls/{send|recv}mmsg: add a test case for timeout
and errno test")

Reported-by: Li Wang <liwang@redhat.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/recvmmsg/recvmmsg01.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
index fe637430b..a16a78f9b 100644
--- a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
+++ b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
@@ -65,7 +65,8 @@ static void do_test(unsigned int i)
 {
 	struct time64_variants *tv = &variants[tst_variant];
 	struct test_case *tc = &tcase[i];
-	void *rcv_msgvec, *timeout;
+	struct tst_ts t;
+	void *rcv_msgvec, *timeout = &t;
 
 	tst_res(TINFO, "case %s", tc->desc);
 
@@ -83,7 +84,7 @@ static void do_test(unsigned int i)
 	memset(rcv1->iov_base, 0, rcv1->iov_len);
 	memset(rcv2->iov_base, 0, rcv2->iov_len);
 
-	timeout.type = tv->ts_type;
+	((struct tst_ts*)timeout)->type = tv->ts_type;
 	tst_ts_set_sec(&ts, tc->tv_sec);
 	tst_ts_set_nsec(&ts, tc->tv_nsec);
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH 1/1] recvmmsg01: Fix compilation
  2020-09-23  9:46 [LTP] [PATCH 1/1] recvmmsg01: Fix compilation Petr Vorel
@ 2020-09-23  9:50 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2020-09-23  9:50 UTC (permalink / raw)
  To: ltp

Hi,

this is wrong, Xao's solution is better:
http://lists.linux.it/pipermail/ltp/2020-September/019060.html

Kind regards,
Petr

> void* cannot be directly used, it must be pointing to the struct.

> recvmmsg01.c:86:9: error: request for member ?type? in something not a
> structure or union
>   timeout.type = tv->ts_type;

> Fixes: 135af8ede ("syscalls/{send|recv}mmsg: add a test case for timeout
> and errno test")

> Reported-by: Li Wang <liwang@redhat.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/kernel/syscalls/recvmmsg/recvmmsg01.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

> diff --git a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> index fe637430b..a16a78f9b 100644
> --- a/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> +++ b/testcases/kernel/syscalls/recvmmsg/recvmmsg01.c
> @@ -65,7 +65,8 @@ static void do_test(unsigned int i)
>  {
>  	struct time64_variants *tv = &variants[tst_variant];
>  	struct test_case *tc = &tcase[i];
> -	void *rcv_msgvec, *timeout;
> +	struct tst_ts t;
> +	void *rcv_msgvec, *timeout = &t;

>  	tst_res(TINFO, "case %s", tc->desc);

> @@ -83,7 +84,7 @@ static void do_test(unsigned int i)
>  	memset(rcv1->iov_base, 0, rcv1->iov_len);
>  	memset(rcv2->iov_base, 0, rcv2->iov_len);

> -	timeout.type = tv->ts_type;
> +	((struct tst_ts*)timeout)->type = tv->ts_type;
>  	tst_ts_set_sec(&ts, tc->tv_sec);
>  	tst_ts_set_nsec(&ts, tc->tv_nsec);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-23  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-23  9:46 [LTP] [PATCH 1/1] recvmmsg01: Fix compilation Petr Vorel
2020-09-23  9:50 ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).