From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Tue, 29 Sep 2020 10:48:09 +0200 Subject: [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported In-Reply-To: <20200929083846.GA2717@yuki.lan> References: <20200929073501.4598-1-pvorel@suse.cz> <20200929083846.GA2717@yuki.lan> Message-ID: <20200929084809.GB7482@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Cyril, > Hi! > > to fix test on kernel built without CONFIG_AIO=y. > > Cleanup: use return instead of else, join string. > This is both obviously ok, but the cleanup should be in a separate > patch. +1, I'll do. I suggested to use tst_syscall(), but we probably want here to use libc wrapper I guess, thus I'll merge this (split into 2 commits). > You can add my reviewed-by if you split the patch into two. > Also is this the only io_* test that fails? > Looking at the testcases we have the io_setup01 that looks like it will > fail with TBROK if io_setup() returns -ENOSYS. Thanks, I'll send a separate patch for this. Kind regards, Petr