From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] vxlan0{3,4}.sh: Fix exit on error
Date: Wed, 30 Sep 2020 12:28:54 +0200 [thread overview]
Message-ID: <20200930102855.5967-1-pvorel@suse.cz> (raw)
we need return, continue was for original loop (in vxlan03.sh regression
from f275363d7, then copy pasted to vxlan04.sh).
Fixes: f275363d7 ("net/{stress,virt}: Migrate virt_lib.sh, ipsec_lib.sh + tests using them")
Fixes: 503b1cb1e ("network: add new gre02, geneve02, macsec03 and vxlan04 tests")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/virt/vxlan03.sh | 2 +-
testcases/network/virt/vxlan04.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/network/virt/vxlan03.sh b/testcases/network/virt/vxlan03.sh
index 9ca303930..ef66a57fe 100755
--- a/testcases/network/virt/vxlan03.sh
+++ b/testcases/network/virt/vxlan03.sh
@@ -40,7 +40,7 @@ do_test()
tst_brk TBROK "you must specify IP address"
fi
- virt_check_cmd virt_add ltp_v0 id 0 $2 || continue
+ virt_check_cmd virt_add ltp_v0 id 0 $2 || return
tst_res TINFO "the same VNI must work"
# VNI is 24 bits long, so max value, which is not reserved, is 0xFFFFFE
diff --git a/testcases/network/virt/vxlan04.sh b/testcases/network/virt/vxlan04.sh
index 0351ea80f..a59b1183f 100755
--- a/testcases/network/virt/vxlan04.sh
+++ b/testcases/network/virt/vxlan04.sh
@@ -24,7 +24,7 @@ do_test()
tst_brk TBROK "you must specify IP address"
fi
- virt_check_cmd virt_add ltp_v0 id 0 $2 || continue
+ virt_check_cmd virt_add ltp_v0 id 0 $2 || return
tst_res TINFO "the same VNI must work"
# VNI is 24 bits long, so max value, which is not reserved, is 0xFFFFFE
--
2.28.0
next reply other threads:[~2020-09-30 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 10:28 Petr Vorel [this message]
2020-09-30 10:28 ` [LTP] [PATCH v2 2/2] virt_lib.sh: Remove checks for tst_ipaddr() output Petr Vorel
2020-09-30 11:43 ` [LTP] [PATCH v2 1/2] vxlan0{3,4}.sh: Fix exit on error Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930102855.5967-1-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox