From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] fanotify: Move safe_fanotify_init() + safe macro into fanotify.h
Date: Wed, 14 Oct 2020 20:02:21 +0200 [thread overview]
Message-ID: <20201014180221.GC19540@dell5510> (raw)
In-Reply-To: <20201014134648.GA13224@yuki.lan>
Hi,
> > Fanotify code is used only in testcases/kernel/syscalls/fanotify/, which
> > justify breaking rule of having safe function and macro outside of
> > library. This will be further cleaned in next commit.
> I guess that this is OK, I doubt that we will need a fanotify_init()
> anywhere else but the fanotify testcases.
Amir acked whole patch some time ago, thus I guess he's not against this first one.
The original motivation was to do further modifications for libc wrapper vs.
syscall() for fanotify_init() and fanotify_mark(). But I guess even without
second commit it makes sense to have all fanotify helpers together.
We can always revert it if really need them as safe macros.
Kind regards,
Petr
next prev parent reply other threads:[~2020-10-14 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 11:35 [LTP] [PATCH 1/2] fanotify: Move safe_fanotify_init() + safe macro into fanotify.h Petr Vorel
2020-04-28 11:35 ` [LTP] [PATCH 2/2] fanotify: Test with tst_variant both raw syscall and libc Petr Vorel
2020-04-28 13:26 ` Amir Goldstein
2020-04-28 13:37 ` Petr Vorel
2020-04-28 15:18 ` Amir Goldstein
2020-04-29 12:06 ` Petr Vorel
2020-04-29 14:27 ` Amir Goldstein
2020-10-14 13:49 ` Cyril Hrubis
2020-10-14 17:56 ` Petr Vorel
2020-10-14 13:46 ` [LTP] [PATCH 1/2] fanotify: Move safe_fanotify_init() + safe macro into fanotify.h Cyril Hrubis
2020-10-14 18:02 ` Petr Vorel [this message]
2020-10-16 3:20 ` Li Wang
2020-10-16 11:35 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014180221.GC19540@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).