From: Michal =?unknown-8bit?q?Koutn=C3=BD?= <mkoutny@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] mm: memcg/slab: Stop reparented obj_cgroups from charging root
Date: Tue, 20 Oct 2020 19:24:02 +0200 [thread overview]
Message-ID: <20201020172402.GD46039@blackbook> (raw)
In-Reply-To: <87mu0hwik7.fsf@suse.de>
Hi.
On Tue, Oct 20, 2020 at 06:52:08AM +0100, Richard Palethorpe <rpalethorpe@suse.de> wrote:
> I don't think that is relevant as we get the memcg from objcg->memcg
> which is set during reparenting. I suppose however, we can determine if
> the objcg was reparented by inspecting memcg->objcg.
+1
> If we just check use_hierarchy then objects directly charged to the
> memcg where use_hierarchy=0 will not be uncharged. However, maybe it is
> better to check if it was reparented and if use_hierarchy=0.
I think (I had to make a table) the yielded condition would be:
if ((memcg->use_hierarchy && reparented) || (!mem_cgroup_is_root(memcg) && !reparented))
__memcg_kmem_uncharge(memcg, nr_pages);
(I admit it's not very readable.)
Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://lists.linux.it/pipermail/ltp/attachments/20201020/e1aefbf7/attachment.sig>
next prev parent reply other threads:[~2020-10-20 17:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:07 [LTP] [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root Richard Palethorpe
2020-10-14 20:08 ` Roman Gushchin
2020-10-16 5:40 ` Richard Palethorpe
2020-10-16 6:32 ` [LTP] [PATCH v2] " Richard Palethorpe
2020-10-16 9:47 ` [LTP] [RFC PATCH] " Michal =?unknown-8bit?q?Koutn=C3=BD?=
2020-10-16 10:41 ` Richard Palethorpe
2020-10-16 15:05 ` Richard Palethorpe
2020-10-16 17:26 ` Michal =?unknown-8bit?q?Koutn=C3=BD?=
2020-10-16 14:53 ` Johannes Weiner
2020-10-16 17:02 ` Roman Gushchin
2020-10-16 17:15 ` Michal =?unknown-8bit?q?Koutn=C3=BD?=
2020-10-19 8:45 ` Richard Palethorpe
2020-10-19 9:58 ` [LTP] [PATCH v3] " Richard Palethorpe
2020-10-19 16:58 ` Shakeel Butt
2020-10-20 5:52 ` Richard Palethorpe
2020-10-20 13:49 ` Richard Palethorpe
2020-10-20 16:56 ` Shakeel Butt
2020-10-21 20:32 ` Roman Gushchin
2020-10-20 17:24 ` Michal =?unknown-8bit?q?Koutn=C3=BD?= [this message]
2020-10-22 7:04 ` Richard Palethorpe
2020-10-22 12:28 ` [LTP] [PATCH v4] " Richard Palethorpe
2020-10-22 16:37 ` Shakeel Butt
2020-10-22 17:25 ` Roman Gushchin
2020-10-22 23:59 ` Shakeel Butt
2020-10-23 0:40 ` Roman Gushchin
2020-10-23 15:44 ` Johannes Weiner
2020-10-23 16:41 ` Shakeel Butt
2020-10-26 7:32 ` Richard Palethorpe
2020-10-26 23:14 ` Roman Gushchin
2020-10-19 22:28 ` [LTP] [RFC PATCH] " Roman Gushchin
2020-10-20 6:04 ` Richard Palethorpe
2020-10-20 12:02 ` Richard Palethorpe
2020-10-20 14:48 ` Richard Palethorpe
2020-10-20 16:27 ` Michal =?unknown-8bit?q?Koutn=C3=BD?=
2020-10-20 17:07 ` Roman Gushchin
2020-10-20 18:18 ` Johannes Weiner
2020-10-21 19:33 ` Roman Gushchin
2020-10-23 16:30 ` Johannes Weiner
2020-11-10 1:27 ` Roman Gushchin
2020-11-10 15:11 ` Shakeel Butt
2020-11-10 19:13 ` Roman Gushchin
2020-11-20 17:46 ` Michal =?unknown-8bit?q?Koutn=C3=BD?=
2020-11-03 13:22 ` Michal Hocko
2020-11-03 21:30 ` Roman Gushchin
2020-10-20 16:55 ` Shakeel Butt
2020-10-20 17:17 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020172402.GD46039@blackbook \
--to=mkoutny@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox