ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V4 2/3] syscalls: select: Verify that data is available to read
Date: Thu, 22 Oct 2020 12:13:36 +0200	[thread overview]
Message-ID: <20201022101336.GC2427@yuki.lan> (raw)
In-Reply-To: <20201022045406.4m6pgqfmwvyx7mh2@vireshk-i7>

Hi!
> > I guess that we still need a test where select would clear the bits from
> > fd->set though, I supposes that the easiest solution would be to add
> > select04.c for that...
> 
> I am not sure how to do that and why would that matter ? :)

So the tests we do have now are checking that the bits in the fdset are
not cleared when there are data ready to be read/written from/to the
filke descriptor, right?

What we need is a test where we ask for a data to be read from an empty
pipe, ask for data to be written to a pipe filled with data (write there
till we get EAGAIN in setup), etc. We can do this with a very short
timeout or even with a timeout set to zero (polling) and check that the
bits were cleared once we have returned from the call.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-10-22 10:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  9:44 [LTP] [PATCH V3 1/3] syscalls: select: Merge few tests and migrate to new format Viresh Kumar
2020-09-08  9:44 ` [LTP] [PATCH V3 2/3] syscalls: select: Verify that data is available to read Viresh Kumar
2020-10-14 12:13   ` Cyril Hrubis
2020-10-19 10:10     ` Viresh Kumar
2020-10-20 13:06       ` Cyril Hrubis
2020-10-21  4:32   ` [LTP] [PATCH V4 " Viresh Kumar
2020-10-21 12:04     ` Cyril Hrubis
2020-10-22  4:54       ` Viresh Kumar
2020-10-22 10:13         ` Cyril Hrubis [this message]
2020-09-08  9:44 ` [LTP] [PATCH V3 3/3] syscalls: select: Rename select04.c to select02.c Viresh Kumar
2020-10-14 12:15   ` Cyril Hrubis
2020-10-19 11:37     ` Viresh Kumar
2020-10-20 13:06       ` Cyril Hrubis
2020-10-21  5:32   ` [LTP] [PATCH V2 4/4] syscalls: select: Add failure tests Viresh Kumar
2020-10-21 14:54     ` Cyril Hrubis
2020-10-06  7:59 ` [LTP] [PATCH V3 1/3] syscalls: select: Merge few tests and migrate to new format Viresh Kumar
2020-10-14 12:05 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022101336.GC2427@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).