From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/5] network/virt: skip setting neighbour table if tunnel doesn't have hwaddr
Date: Mon, 26 Oct 2020 08:06:41 +0100 [thread overview]
Message-ID: <20201026070641.GD21306@dell5510> (raw)
In-Reply-To: <20201015122056.20715-3-alexey.kodanev@oracle.com>
Hi Alexey,
good idea.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> diff --git a/testcases/network/virt/virt_lib.sh b/testcases/network/virt/virt_lib.sh
> index 80b9bcc90..f62120347 100644
> --- a/testcases/network/virt/virt_lib.sh
> +++ b/testcases/network/virt/virt_lib.sh
> @@ -229,10 +229,13 @@ virt_minimize_timeout()
> local mac_loc="$(cat /sys/class/net/ltp_v0/address)"
> local mac_rmt="$(tst_rhost_run -c 'cat /sys/class/net/ltp_v0/address')"
> - ROD_SILENT "ip ne replace $ip_virt_remote lladdr \
> - $mac_rmt nud permanent dev ltp_v0"
> - tst_rhost_run -s -c "ip ne replace $ip_virt_local lladdr \
> - $mac_loc nud permanent dev ltp_v0"
> + if [ "$mac_loc" ]; then
NOTE: I guess it's safe to check only $mac_rmt (and not $mac_rmt)
> + ROD_SILENT "ip ne replace $ip_virt_remote lladdr \
> + $mac_rmt nud permanent dev ltp_v0"
> + tst_rhost_run -s -c "ip ne replace $ip_virt_local lladdr \
> + $mac_loc nud permanent dev ltp_v0"
> + fi
> +
> virt_tcp_syn=$(sysctl -n net.ipv4.tcp_syn_retries)
> ROD sysctl -q net.ipv4.tcp_syn_retries=1
> }
Kind regards,
Petr
next prev parent reply other threads:[~2020-10-26 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 12:20 [LTP] [PATCH 1/5] lib/tst_net: add generic tst_netload_compare() Alexey Kodanev
2020-10-15 12:20 ` [LTP] [PATCH 2/5] lib/tst_net: calc mean in tst_netload() Alexey Kodanev
2020-10-20 14:39 ` Petr Vorel
2020-10-21 9:56 ` Alexey Kodanev
2020-10-26 6:46 ` Petr Vorel
2020-10-15 12:20 ` [LTP] [PATCH 3/5] network/virt: skip setting neighbour table if tunnel doesn't have hwaddr Alexey Kodanev
2020-10-26 7:06 ` Petr Vorel [this message]
2020-10-15 12:20 ` [LTP] [PATCH 4/5] network/virt: add wireguard01 Alexey Kodanev
2020-10-26 8:49 ` Petr Vorel
2020-10-26 13:40 ` Alexey Kodanev
2020-10-26 13:45 ` Petr Vorel
2020-10-15 12:20 ` [LTP] [PATCH 5/5] network/virt: add wireguard02: ipsec vs wireguard Alexey Kodanev
2020-10-26 8:53 ` Petr Vorel
2020-10-30 15:20 ` Alexey Kodanev
2020-10-20 13:52 ` [LTP] [PATCH 1/5] lib/tst_net: add generic tst_netload_compare() Petr Vorel
2020-10-21 9:18 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026070641.GD21306@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox