From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Thu, 29 Oct 2020 16:59:07 +0100
Subject: [LTP] [PATCH 04/19] Unify error handling in lib/safe_file_ops.c
In-Reply-To: <20201026164756.30556-5-mdoucha@suse.cz>
References: <20201026164756.30556-1-mdoucha@suse.cz>
 <20201026164756.30556-5-mdoucha@suse.cz>
Message-ID: <20201029155907.GC8378@yuki.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> diff --git a/lib/safe_file_ops.c b/lib/safe_file_ops.c
> index e06d399fa..a63368875 100644
> --- a/lib/safe_file_ops.c
> +++ b/lib/safe_file_ops.c
> @@ -84,9 +84,8 @@ int file_scanf(const char *file, const int lineno,
>  	f = fopen(path, "r");
>  
>  	if (f == NULL) {
> -		tst_resm(TWARN,
> -			"Failed to open FILE '%s' at %s:%d",
> -			 path, file, lineno);
> +		tst_resm_(file, lineno, TWARN, "Failed to open FILE '%s'",
> +			path);
>  		return 1;

scanf() returns negative value on error, I guess it would make more
sense to return -1 here and in many cases below.

-- 
Cyril Hrubis
chrubis@suse.cz