From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Fri, 30 Oct 2020 14:12:14 +0100
Subject: [LTP] [PATCH] syscalls/statx05: add mkfs.ext4 package version
 check
In-Reply-To: <20201029140031.40968-1-po-hsu.lin@canonical.com>
References: <20201029140031.40968-1-po-hsu.lin@canonical.com>
Message-ID: <20201030131214.GA32451@yuki.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> +	int ret, rc, major, minor, patch;
> +
> +	f = SAFE_POPEN("mkfs.ext4 -V 2>&1 | awk '/mke2fs/ {print $2}'", "r");
> +	rc = fscanf(f, "%d.%d.%d", &major, &minor, &patch);

I wonder if the awk is necessary, it may produce TWARN on minimal
embedded systems where awk is not present. Why can't we use scanf() instead?

As far as I can tell fscanf(f, "mke2fs %d.%d.%d", &major, &minor,
&patch); should work fine without the awk.

-- 
Cyril Hrubis
chrubis@suse.cz