From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCHv2] syscalls/quotactl04: add mkfs.ext4 package version check
Date: Wed, 4 Nov 2020 23:42:21 +0100 [thread overview]
Message-ID: <20201104224221.GA20360@pevik> (raw)
In-Reply-To: <CAMy_GT-wq+=oYMgyZsVgpZxJ4vU-6PJR2OfWoPx2L=9jDjRo3g@mail.gmail.com>
Hi,
> On Wed, Nov 4, 2020 at 3:12 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com> wrote:
> > Hi Po-Hsu
> > > The project quota feature was added in e2fsprogs 1.43 [1]:
> > > E2fsprogs 1.43 (May 17, 2016)
> > > Add support for the ext4 metadata checksum, checksum seed, inline
> > > data, encryption, project quota, and read-only features.
> > > The test should be skipped when running with older package, otherwise
> > > it will fail with:
> > > Invalid filesystem option set: quota,project
> > > Use popen and fscanf to get mkfs.ext4 -V output for version
> > > comparison. This version checking by adding digits together does not
> > > work with alphabets in the number like rc1, but in that case the test
> > > will still be tested.
> > > It will now be skipped with (Tested with Ubuntu Xenial + 4.15 kernel):
> > > quotactl04.c:118: TCONF: Test needs mkfs.ext4>= 1.43 for encrypt
> > > option, test skipped
> > Commit message is also wrong. But I think maintainer will correct this
> > and don't need to send a v3.
> My apology for this.
> That would be great.
> Thanks!
Fixed commit message and merged.
Thanks!
Kind regards,
Petr
prev parent reply other threads:[~2020-11-04 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 7:04 [LTP] [PATCHv2] syscalls/quotactl04: add mkfs.ext4 package version check Po-Hsu Lin
2020-11-04 7:12 ` Yang Xu
2020-11-04 12:52 ` Po-Hsu Lin
2020-11-04 22:42 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104224221.GA20360@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).