From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Add tst_secureboot_enabled() helper function
Date: Mon, 9 Nov 2020 16:15:03 +0100 [thread overview]
Message-ID: <20201109151503.GA15566@pevik> (raw)
In-Reply-To: <9d91a462-9aa1-eb1f-6bfc-c2db28967840@suse.cz>
Hi Martin, Cyril,
...
> >> diff --git a/include/mk/config.mk.in b/include/mk/config.mk.in
> >> index 427608a17..cffd11245 100644
> >> --- a/include/mk/config.mk.in
> >> +++ b/include/mk/config.mk.in
> >> @@ -56,8 +56,8 @@ libdir := @libdir@
> >> mandir := @mandir@
> >> CPPFLAGS := @CPPFLAGS@
> >> -CFLAGS := @CFLAGS@
> >> -LDLIBS := @LIBS@
> >> +CFLAGS := @CFLAGS@ @EFIVAR_CFLAGS@
> >> +LDLIBS := @LIBS@ @EFIVAR_LIBS@
> > Please do not do this.
> > This should be handled like any other library, i.e. we should define
> > EFIVAR_CFLAGS and EFIVAR_LIBS and use them in respective Makefile.
+1 (and sorry for overlooking this).
Kind regards,
Petr
prev parent reply other threads:[~2020-11-09 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:32 [LTP] [PATCH v2] Add tst_secureboot_enabled() helper function Martin Doucha
2020-11-09 13:56 ` Cyril Hrubis
2020-11-09 14:10 ` Martin Doucha
2020-11-09 15:15 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109151503.GA15566@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).