From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] tcp_cmds/ping/ping02: Make it compatible with Busybox
Date: Tue, 10 Nov 2020 13:28:54 +0100 [thread overview]
Message-ID: <20201110122854.GA30193@pevik> (raw)
In-Reply-To: <20201109191618.4442-1-kory.maincent@bootlin.com>
Hi Kory, Alexey,
> The ping from busybox does not have -f parameter, use -i parameter instead.
> BusyBox does not accept pattern longer than 2 bytes.
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Changes since v1:
> - Use "-i 0.01 -p aa" parameter instead of "-f"
> Changes since v2:
> - Use "-i 0.01 -p aa" only in the case of "-f" parameter is not valid
Reviewed-by: Petr Vorel <pvorel@suse.cz>
-i option was added in busybox 1.30 (2 years old), it'd be good to note that in
the commit message.
I have in my TODO list C/shell API helper which would help to verify command
version.
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-10 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 19:16 [LTP] [PATCH v3] tcp_cmds/ping/ping02: Make it compatible with Busybox Kory Maincent
2020-11-10 12:28 ` Petr Vorel [this message]
2020-11-10 12:36 ` Petr Vorel
2020-11-10 14:31 ` Alexey Kodanev
2020-11-10 14:54 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110122854.GA30193@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).