From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] tcp_cmds/ping/ping02: Make it compatible with Busybox
Date: Tue, 10 Nov 2020 15:54:58 +0100 [thread overview]
Message-ID: <20201110145458.GA13043@pevik> (raw)
In-Reply-To: <48e1bd71-021d-d405-fd67-c35dcd8b53e2@oracle.com>
Hi Kory, Alexey,
> On 10.11.2020 15:36, Petr Vorel wrote:
> > Hi Kory, Alexey,
> >> -i option was added in busybox 1.30 (2 years old), it'd be good to note that in
> >> the commit message.
> > Actually, maybe also test -i option and if even -i not working run?
> > tst_brk TCONF "unsupported ping version (old busybox?)"
> Hi Petr,
> What if it failed for some other reason, it would be a wrong assumption
> that ping doesn't support -i...
Yep, that'd be bad.
Thus maybe just check
$PING 2>&1 |grep -q -- -i
in case of busybox?
If you don't like it, at least put tst_res TINFO message in case of busybox.
(but I'd prefer this check).
And maybe move $ping_opts and this check to setup.
Kind regards,
Petr
prev parent reply other threads:[~2020-11-10 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 19:16 [LTP] [PATCH v3] tcp_cmds/ping/ping02: Make it compatible with Busybox Kory Maincent
2020-11-10 12:28 ` Petr Vorel
2020-11-10 12:36 ` Petr Vorel
2020-11-10 14:31 ` Alexey Kodanev
2020-11-10 14:54 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110145458.GA13043@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).