From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] tcp_cmds/ping/ping02: Make it compatible with Busybox
Date: Wed, 11 Nov 2020 16:06:35 +0100 [thread overview]
Message-ID: <20201111150635.GA4291@pevik> (raw)
In-Reply-To: <5fab0669-9597-8e20-4f6b-3c21da0e125c@oracle.com>
Hi Kory, Alexey,
> >> The ping from busybox does not have -f parameter, use -i parameter instead.
> >> BusyBox does not accept pattern longer than 2 bytes.
> >> BusyBox support -i option since version 1.30
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Tested-by: Petr Vorel <pvorel@suse.cz>
> > LGTM.
> > I suggest to merge with few changes below.
> > * more precise message "ping from old busybox?"
> > * use just $(tst_ipaddr rhost) instead of $ipaddr
> > (some time ago we've started to use function calls for these simple evaluations)
> > * upper case for global variable (ugly, but easily recognizable
> Hi Petr,
> Feel free to add the style changes, ack. I've already applied the patch.
> Thanks Kory!
Let's leave it as it is, not that important.
Thanks a lot both.
Kind regards,
Petr
prev parent reply other threads:[~2020-11-11 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 18:05 [LTP] [PATCH v4] tcp_cmds/ping/ping02: Make it compatible with Busybox Kory Maincent
2020-11-11 14:40 ` Petr Vorel
2020-11-11 15:01 ` Alexey Kodanev
2020-11-11 15:06 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111150635.GA4291@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).