ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
* [LTP] [PATCH] network/traceroute01: make it compatible with Busybox
@ 2020-11-12 14:56 Kory Maincent
  2020-11-12 17:41 ` Petr Vorel
  0 siblings, 1 reply; 3+ messages in thread
From: Kory Maincent @ 2020-11-12 14:56 UTC (permalink / raw)
  To: ltp

Busybox has not "-T" parameter, return TCONF in that case.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 testcases/network/traceroute/traceroute01.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/testcases/network/traceroute/traceroute01.sh b/testcases/network/traceroute/traceroute01.sh
index 821853f0e..5b4a6d5a2 100755
--- a/testcases/network/traceroute/traceroute01.sh
+++ b/testcases/network/traceroute/traceroute01.sh
@@ -56,7 +56,11 @@ test1()
 test2()
 {
 	tst_res TINFO "run traceroute with TCP SYN"
-	run_trace -T
+	if traceroute -T 2>&1 | grep -q "invalid option"; then
+		tst_res TCONF "Wrong version of traceroute, traceroute from busybox can not use TCP SYN"
+	else
+		run_trace -T
+	fi
 }
 
 tst_run
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] network/traceroute01: make it compatible with Busybox
  2020-11-12 14:56 [LTP] [PATCH] network/traceroute01: make it compatible with Busybox Kory Maincent
@ 2020-11-12 17:41 ` Petr Vorel
  2020-11-12 17:48   ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-11-12 17:41 UTC (permalink / raw)
  To: ltp

Hi Kory,

> Busybox has not "-T" parameter, return TCONF in that case.
Thanks, merged with slightly updated message.
+ followup patch:
https://patchwork.ozlabs.org/project/ltp/patch/20201112173609.4123-1-petr.vorel@suse.com/

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] network/traceroute01: make it compatible with Busybox
  2020-11-12 17:41 ` Petr Vorel
@ 2020-11-12 17:48   ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
  0 siblings, 0 replies; 3+ messages in thread
From: =?unknown-8bit?q?K=C3=B6ry?= Maincent @ 2020-11-12 17:48 UTC (permalink / raw)
  To: ltp

Hi Petr,

On Thu, 12 Nov 2020 18:41:34 +0100
Petr Vorel <pvorel@suse.cz> wrote:

> Hi Kory,
> 
> > Busybox has not "-T" parameter, return TCONF in that case.  
> Thanks, merged with slightly updated message.
> + followup patch:
> https://patchwork.ozlabs.org/project/ltp/patch/20201112173609.4123-1-petr.vorel@suse.com/

Ok thanks.

Regards,

> 
> Kind regards,
> Petr



-- 
K?ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-12 17:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 14:56 [LTP] [PATCH] network/traceroute01: make it compatible with Busybox Kory Maincent
2020-11-12 17:41 ` Petr Vorel
2020-11-12 17:48   ` =?unknown-8bit?q?K=C3=B6ry?= Maincent

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).