From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] loop: Fix occasional uevent drop
Date: Thu, 12 Nov 2020 20:25:40 +0100 [thread overview]
Message-ID: <20201112192540.GB14767@pevik> (raw)
In-Reply-To: <20201112165005.4022502-3-hch@lst.de>
Hi Christoph,
> From: Petr Vorel <pvorel@suse.cz>
Thanks for rebasing my code. Using loop.c specific code in the file instead of
the function is indeed much better.
I also like your cleanup for 5.11 (remove the update_bdev parameter from
set_capacity_revalidate_and_notify).
> Commit 716ad0986cbd ("loop: Switch to set_capacity_revalidate_and_notify")
> causes an occasional drop of loop device uevent, which are no longer
> triggered in loop_set_size() but in a different part of code.
> Bug is reproducible with LTP test uevent01 [1]:
> i=0; while true; do
> i=$((i+1)); echo "== $i =="
> lsmod |grep -q loop && rmmod -f loop
> ./uevent01 || break
> done
> Put back triggering through code called in loop_set_size().
> Fix required to add yet another parameter to
> set_capacity_revalidate_and_notify().
This ^ is no longer true and should be removed.
Kind regards,
Petr
prev parent reply other threads:[~2020-11-12 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201112165005.4022502-1-hch@lst.de>
2020-11-12 16:50 ` [LTP] [PATCH 2/2] loop: Fix occasional uevent drop Christoph Hellwig
2020-11-12 19:25 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112192540.GB14767@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).