From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 00/11] Test metadata extraction
Date: Fri, 13 Nov 2020 18:06:52 +0100 [thread overview]
Message-ID: <20201113170652.GA29443@pevik> (raw)
In-Reply-To: <20201112131139.GA4962@pevik>
Hi Li,
...
> Anybody against pushing whole patchset [1] with fix below for third commit
> ("docparse: Add test documentation parser").
Going to merge whole patchset with diff below
(https://github.com/pevik/ltp/commits/test-metadata-extraction.v2.fixes).
Can I add you Reviewed-by: tag to whole patchset or a subset?
Kind regards,
Petr
> Kind regards,
> Petr
> [1] https://patchwork.ozlabs.org/project/ltp/list/?series=211956&state=*
> Fix for third commit:
> diff --git docparse/docparse.c docparse/docparse.c
> index 63d131c87..be6125353 100644
> --- docparse/docparse.c
> +++ docparse/docparse.c
> @@ -138,10 +138,8 @@ const char *next_token(FILE *f, struct data_node *doc)
> if (in_str) {
> if (c == '"') {
> - if (i == 0 || buf[i-1] != '\\') {
> - buf[i++] = c;
> + if (i == 0 || buf[i-1] != '\\')
> goto exit;
> - }
> }
> buf[i++] = c;
> @@ -189,7 +187,7 @@ const char *next_token(FILE *f, struct data_node *doc)
> }
> exit:
> - if (i == 0)
> + if (i == 0 && !in_str)
> return NULL;
> buf[i] = 0;
next prev parent reply other threads:[~2020-11-13 17:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 19:13 [LTP] [PATCH v2 00/11] Test metadata extraction Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 01/11] make: Support compiling native build tools Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 02/11] travis: Add git Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 03/11] docparse: Add test documentation parser Petr Vorel
2020-11-04 7:30 ` Petr Vorel
2020-11-04 13:20 ` Li Wang
2020-11-04 16:37 ` Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 04/11] docparse: Add README Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 05/11] syscalls: Add a few documentation comments Petr Vorel
2020-11-04 11:34 ` Radoslav Kolev
2020-11-04 15:54 ` Petr Vorel
2020-11-05 12:48 ` Cyril Hrubis
2020-11-05 12:48 ` Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 06/11] syscalls: Move needs_drivers inside of the tst_test struct Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 07/11] make: Allow {INSTALL, MAKE}_TARGETS be a directory Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 08/11] make: Allow CLEAN_TARGETS to remove directories Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 09/11] travis: Install docparse dependencies Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 10/11] docparse: Add configure options Petr Vorel
2020-11-03 19:13 ` [LTP] [PATCH v2 11/11] docparse: Generate html and pdf using asciidoc{, tor} Petr Vorel
2020-11-12 13:11 ` [LTP] [PATCH v2 00/11] Test metadata extraction Petr Vorel
2020-11-13 17:06 ` Petr Vorel [this message]
2020-11-16 6:21 ` Li Wang
2020-11-16 6:30 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113170652.GA29443@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).