ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/5] fanotify: Handle supported features checks in setup()
Date: Fri, 13 Nov 2020 21:12:27 +0100	[thread overview]
Message-ID: <20201113201227.GA92818@pevik> (raw)
In-Reply-To: <CAOQ4uxhWOaarVWE6r_EgvtqSV83WeVghp+crAMo5UpC4KxeP9Q@mail.gmail.com>

Hi Amir,

> > > +++ b/testcases/kernel/syscalls/fanotify/fanotify03.c
> > > @@ -212,28 +212,23 @@ static int setup_mark(unsigned int n)
> > >         char *const files[] = {fname, FILE_EXEC_PATH};

> > >         tst_res(TINFO, "Test #%d: %s", n, tc->tname);
> > > +
> > > +       if (support_exec_events != 0 && tc->mask & FAN_OPEN_EXEC_PERM) {
> > > +               tst_res(TCONF | TERRNO, "FAN_OPEN_EXEC_PERM not supported in kernel?");
> > > +               return -1;
> > > +       }
> > > +

> Please remove the comment above tcases[] definition:
> "Ensure to keep the first..."

> It is no longer needed after this change.
+1 (this one is easy).
FYI I've sent v3, but that does not address your comments
(just fixes failure).

I'll have look into your comments next week.

> Thanks,
> Amir.

Kind regards,
Petr

  reply	other threads:[~2020-11-13 20:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 15:51 [LTP] [PATCH v2 0/5] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-11-13 15:51 ` [LTP] [PATCH v2 1/5] fanotify12: Drop incorrect hint Petr Vorel
2020-11-13 15:51 ` [LTP] [PATCH v2 2/5] fanotify: Handle supported features checks in setup() Petr Vorel
2020-11-13 18:33   ` Amir Goldstein
2020-11-13 18:52     ` Amir Goldstein
2020-11-13 20:12       ` Petr Vorel [this message]
2020-11-13 15:51 ` [LTP] [PATCH v2 3/5] fanotify: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-11-13 19:08   ` Amir Goldstein
2020-11-13 15:51 ` [LTP] [PATCH v2 4/5] fanotify: Check FAN_REPORT_{FID, NAME} support Petr Vorel
2020-11-13 15:51 ` [LTP] [PATCH v2 5/5] fanotify: Add a pedantic check for return value Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113201227.GA92818@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).