From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 01/10] lib: Introduce more TEST_* macros
Date: Fri, 13 Nov 2020 21:28:28 +0100 [thread overview]
Message-ID: <20201113202828.GA2229@pevik> (raw)
In-Reply-To: <20201113131428.13199-2-chrubis@suse.cz>
> In order to simplify common return value checks.
Great improvement, thanks!
The only concern I have is for tests which does not end 0
as it's not obvious from the output (without looking into the test source)
that everything it's working, but not a big deal.
FYI I plan to send a patchset which runs tests in lib/newlib_tests/.
First I thought simple check for 0 would be ok, but with non-zero results it
might be good to not only check expected return value but maybe for whole
output (the same approach we have unfinished in patchset from Christian Lanig).
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-13 20:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:14 [LTP] [PATCH 00/10] Introduce TEST_MACROS Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 01/10] lib: Introduce more TEST_* macros Cyril Hrubis
2020-11-13 20:28 ` Petr Vorel [this message]
2020-11-16 8:41 ` Li Wang
2020-11-19 13:08 ` Cyril Hrubis
2020-11-25 13:18 ` Cyril Hrubis
2020-11-25 13:33 ` Li Wang
2020-11-25 15:57 ` Cyril Hrubis
2020-11-26 2:17 ` Li Wang
2020-11-19 13:09 ` Cyril Hrubis
2020-11-25 16:54 ` Martin Doucha
2020-12-03 12:30 ` Cyril Hrubis
2020-12-03 14:34 ` Martin Doucha
2020-11-13 13:14 ` [LTP] [PATCH 02/10] syscalls/uname: Make use of TEST_MACROS Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 03/10] syscalls/accept: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 04/10] syscalls/access: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 05/10] syscalls/bind: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 06/10] syscalls/brk01: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 07/10] syscalls/cacheflush: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 08/10] syscalls/capget: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 09/10] syscalls/capset: " Cyril Hrubis
2020-11-13 13:14 ` [LTP] [PATCH 10/10] syscalls/open: " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113202828.GA2229@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox