public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Define SYS_futex on 32bit arches using 64-bit time_t
Date: Mon, 16 Nov 2020 18:03:20 +0100	[thread overview]
Message-ID: <20201116170320.GC152616@pevik> (raw)
In-Reply-To: <CAMKF1sqjVMexm38VVt=grmL-K63=hyfA-0aoNyi=53TyFVXJ0w@mail.gmail.com>

Hi Khem,

> On Sun, Nov 15, 2020 at 11:08 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Khem,

> > > Newer 32bit arches like RISCV32 and ARC are using 64bit time_t
> > > from get go unlike other 32bit architecture therefore aliasing
> > __NR_futex to
> > > __NR_futex_time64 helps avoid the below errors

> > > tst_checkpoint.c:99:17: error: use of undeclared identifier 'SYS_futex'

> > Thanks for your fix.

> > I wonder if this could be defined just in include/lapi/futex.h and this:


> > https://github.com/pevik/ltp/commit/a20107ab47554798e0de0347dd4d7259f01675af


> It could be but it did not work everywhere when I tried it I guess this
> header has to be included in all needed placed

Sure, but that's done :)

You put the changes into 3 files:
lib/tst_checkpoint.c
testcases/kernel/syscalls/clone/clone08.c
testcases/kernel/syscalls/futex/futextest.h

Check the affected files:

I put changes into include/lapi/futex.h
and load it in
testcases/kernel/syscalls/clone/clone08.c

The other two (testcases/kernel/syscalls/clone/clone08.c
testcases/kernel/syscalls/futex/futextest.h) already include lapi/futex.h.

Are you sure it's failing when you try my patchset?

Kind regards,
Petr

  reply	other threads:[~2020-11-16 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  0:33 [LTP] [PATCH] Define SYS_futex on 32bit arches using 64-bit time_t Khem Raj
2020-11-16  7:08 ` Petr Vorel
2020-11-16 16:07   ` Khem Raj
2020-11-16 17:03     ` Petr Vorel [this message]
2020-11-16 18:03       ` Khem Raj
2020-11-16 18:19         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116170320.GC152616@pevik \
    --to=petr.vorel@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox