From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/5] fanotify12: Drop incorrect hint
Date: Thu, 19 Nov 2020 11:06:43 +0100 [thread overview]
Message-ID: <20201119100643.GB2785@yuki.lan> (raw)
In-Reply-To: <20201113164944.26101-2-pvorel@suse.cz>
Hi!
> hint "CONFIG_FANOTIFY_ACCESS_PERMISSIONS not configured in kernel?"
> is wrong here (fanotify12 does not use FAN_ACCESS_PERM).
>
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/syscalls/fanotify/fanotify12.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify12.c b/testcases/kernel/syscalls/fanotify/fanotify12.c
> index fcb7ec0d3..7f23fc9dc 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify12.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify12.c
> @@ -146,10 +146,6 @@ static int setup_mark(unsigned int n)
> "FAN_OPEN_EXEC not supported in "
> "kernel?");
> return -1;
> - } else if (errno == EINVAL) {
> - tst_brk(TCONF | TERRNO,
> - "CONFIG_FANOTIFY_ACCESS_PERMISSIONS "
> - "not configured in kernel?");
> }else {
> tst_brk(TBROK | TERRNO,
> "fanotify_mark(%d, FAN_MARK_ADD | %s, "
Looking at the source there is the same message just couple of lines
below this one, should we get rid of that one as well?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-11-19 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 16:49 [LTP] [PATCH v3 0/5] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-11-13 16:49 ` [LTP] [PATCH v3 1/5] fanotify12: Drop incorrect hint Petr Vorel
2020-11-19 10:06 ` Cyril Hrubis [this message]
2020-11-13 16:49 ` [LTP] [PATCH v3 2/5] fanotify: Handle supported features checks in setup() Petr Vorel
2020-11-19 10:16 ` Cyril Hrubis
2020-11-25 16:56 ` Petr Vorel
2020-11-13 16:49 ` [LTP] [PATCH v3 3/5] fanotify: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-11-19 10:27 ` Cyril Hrubis
2020-11-19 10:54 ` Amir Goldstein
2020-11-25 14:16 ` Petr Vorel
2020-11-25 15:41 ` Amir Goldstein
2020-11-25 18:24 ` Petr Vorel
2020-11-25 19:55 ` Amir Goldstein
2020-11-25 20:25 ` Petr Vorel
2020-11-26 3:00 ` Amir Goldstein
2020-11-13 16:49 ` [LTP] [PATCH v3 4/5] fanotify: Check FAN_REPORT_{FID, NAME} support Petr Vorel
2020-11-19 10:30 ` Cyril Hrubis
2020-11-13 16:49 ` [LTP] [PATCH v3 5/5] fanotify: Add a pedantic check for return value Petr Vorel
2020-11-19 10:31 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119100643.GB2785@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox